Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 10928194: explicitly set VSNaClSDKRoot in vcxproj rather than (Closed)

Created:
8 years, 3 months ago by Sam Clegg
Modified:
8 years, 3 months ago
Reviewers:
noelallen1
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Explicitly set VSNaClSDKRoot in vcxproj rather than relying on defaults. VSNaClSDKRoot must be set before any other properties that depend on it. In order to make sure the ordering is correct we unset certain properties and then re-set them back to their original values following the setting of VSNaClSDKRoot. BUG=http://code.google.com/p/chromium/issues/detail?id=148794 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1414

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj View 1 2 3 2 chunks +13 lines, -11 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs View 1 2 3 4 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
8 years, 3 months ago (2012-09-13 23:00:34 UTC) #1
noelallen1
A few nits otherwise LGTM http://codereview.chromium.org/10928194/diff/3001/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs File visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs (right): http://codereview.chromium.org/10928194/diff/3001/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs#newcode181 visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs:181: if (true) //properties.NaClAddInVersion != ...
8 years, 3 months ago (2012-09-14 20:47:20 UTC) #2
Sam Clegg
8 years, 3 months ago (2012-09-14 23:31:16 UTC) #3
http://codereview.chromium.org/10928194/diff/3001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs (right):

http://codereview.chromium.org/10928194/diff/3001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs:181: if (true)
//properties.NaClAddInVersion != naclAddInVersion)
On 2012/09/14 20:47:20, noelallen1 wrote:
> Test code?  Comment or remove.

oops!

Done

http://codereview.chromium.org/10928194/diff/3001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs:184:
//MessageBox.Show("Modifying Config: " + config.Name);
On 2012/09/14 20:47:20, noelallen1 wrote:
> Remove

Done.

Powered by Google App Engine
This is Rietveld 408576698