Enable web components for shell windows based on their render view type, rather than their origin.

Enable web components for shell windows based on their render view type, rather than their origin.

This fixes a bug where an app could load a sandboxed resource in the window
(which has a unique origin), and the HTML titlebar would lack styling due to
the absence of <style scoped> support.

BUG=149002
R=mihaip@chromium.org
TBR=jhawkins@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156711

[Mihai Parparita -not on Chrome, 2012-09-13 20:17:36]

https://chromiumcodereview.appspot.com/10928188/diff/1/chrome/renderer/chrome...
File chrome/renderer/chrome_render_view_observer.cc (right):

https://chromiumcodereview.appspot.com/10928188/diff/1/chrome/renderer/chrome...
chrome/renderer/chrome_render_view_observer.cc:535: // XXX perhaps we should
only use this check, and remove the above checks?
I'd rather keep the permission-based checks where possible, since they document
intent better.

This should have a comment saying that it covers the shell window/custom
titlebar scenario.

https://chromiumcodereview.appspot.com/10928188/diff/1/chrome/renderer/chrome...
chrome/renderer/chrome_render_view_observer.cc:538: // XXX is there always an
ExtensionHelper for every RenderView?
Yes. We create one as soon as the RenderView is created:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/renderer/chrome_con...

[jeremya, 2012-09-13 21:27:23]

Done.

[Mihai Parparita -not on Chrome, 2012-09-13 21:28:30]

LGTM

[commit-bot: I haz the power, 2012-09-13 21:53:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10928188/5001

[commit-bot: I haz the power, 2012-09-13 21:53:22]

Presubmit check for 10928188-5001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[jeremya, 2012-09-13 22:04:45]

TBRing jhawkins for OWNERS rubber-stamp

[commit-bot: I haz the power, 2012-09-13 22:05:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10928188/5001

[James Hawkins, 2012-09-13 22:05:50]

LGTM with nit.

https://chromiumcodereview.appspot.com/10928188/diff/5001/chrome/renderer/chr...
File chrome/renderer/chrome_render_view_observer.cc (right):

https://chromiumcodereview.appspot.com/10928188/diff/5001/chrome/renderer/chr...
chrome/renderer/chrome_render_view_observer.cc:536: // will be unique (i.e. the
empty string), so we have to go by the view
nit: Don't use pronouns (we) in comments; pronouns are ambiguous.

[commit-bot: I haz the power, 2012-09-13 22:14:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10928188/14001

[commit-bot: I haz the power, 2012-09-14 02:04:20]

Change committed as 156711