Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 10928170: Add IsEmpty() check to ModuleSystem::IsPresentInCurrentContext(). (Closed)

Created:
8 years, 3 months ago by koz (OOO until 15th September)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add IsEmpty() check to ModuleSystem::IsPresentInCurrentContext(). BUG=134977 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/renderer/extensions/module_system.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koz (OOO until 15th September)
I can never get enough of adding IsEmpty() checks :-)
8 years, 3 months ago (2012-09-13 00:49:04 UTC) #1
not at google - send to devlin
lgtm sheesh
8 years, 3 months ago (2012-09-13 00:52:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/10928170/1
8 years, 3 months ago (2012-09-13 00:58:17 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 03:03:28 UTC) #4
Change committed as 156483

Powered by Google App Engine
This is Rietveld 408576698