runtime/vm/flow_graph_builder.cc - Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_builder.cc

===================================================================

--- runtime/vm/flow_graph_builder.cc (revision 12282)

+++ runtime/vm/flow_graph_builder.cc (working copy)

@@ -2353,7 +2353,7 @@

if (node == owner()->parsed_function().node_sequence()) {

ASSERT(scope->context_level() == 1);

const Function& function = owner()->parsed_function().function();

- int num_params = function.NumberOfParameters();

+ int num_params = function.NumParameters();

int param_frame_index = (num_params == function.num_fixed_parameters()) ?

(1 + num_params) : ParsedFunction::kFirstLocalSlotIndex;

// Handle the saved arguments descriptor as an additional parameter.

@@ -2391,7 +2391,7 @@

if (FLAG_enable_type_checks &&

(node == owner()->parsed_function().node_sequence())) {

const Function& function = owner()->parsed_function().function();

- const int num_params = function.NumberOfParameters();

+ const int num_params = function.NumParameters();

int pos = 0;

if (function.IsConstructor()) {

// Skip type checking of receiver and phase for constructor functions.

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | runtime/vm/object.h » ('J')