Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: runtime/vm/object_test.cc

Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 12282)
+++ runtime/vm/object_test.cc (working copy)
@@ -39,11 +39,11 @@
false, false, false, false, cls, 0);
const int kNumFixedParameters = 2;
- const int kNumOptionalParameters = 3;
- const bool kAreOptionalPositional = true;
- function.SetNumberOfParameters(kNumFixedParameters,
- kNumOptionalParameters,
- kAreOptionalPositional);
+ const int kNumOptionalPositionalParameters = 3;
+ const int kNumOptionalNamedParameters = 0;
+ function.set_num_fixed_parameters(kNumFixedParameters);
+ function.SetNumOptionalParameters(kNumOptionalPositionalParameters,
+ kNumOptionalNamedParameters);
functions.SetAt(1, function);
function_name = Symbols::New("baz");
@@ -99,9 +99,7 @@
function = cls.LookupDynamicFunction(function_name);
EXPECT(!function.IsNull());
EXPECT_EQ(kNumFixedParameters, function.num_fixed_parameters());
- EXPECT_EQ(kNumOptionalParameters,
- function.num_optional_positional_parameters() +
- function.num_optional_named_parameters());
+ EXPECT_EQ(kNumOptionalPositionalParameters, function.NumOptionalParameters());
const Array& interfaces = Array::Handle(Array::New(2));
Class& interface = Class::Handle();
« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698