Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 } 618 }
619 619
620 620
621 void FlowGraphCompiler::CopyParameters() { 621 void FlowGraphCompiler::CopyParameters() {
622 __ Comment("Copy parameters"); 622 __ Comment("Copy parameters");
623 const Function& function = parsed_function().function(); 623 const Function& function = parsed_function().function();
624 const bool is_native_instance_closure = 624 const bool is_native_instance_closure =
625 function.is_native() && function.IsImplicitInstanceClosureFunction(); 625 function.is_native() && function.IsImplicitInstanceClosureFunction();
626 LocalScope* scope = parsed_function().node_sequence()->scope(); 626 LocalScope* scope = parsed_function().node_sequence()->scope();
627 const int num_fixed_params = function.num_fixed_parameters(); 627 const int num_fixed_params = function.num_fixed_parameters();
628 const int num_opt_pos_params = function.num_optional_positional_parameters(); 628 const int num_opt_pos_params = function.NumOptionalPositionalParameters();
629 int num_opt_named_params = function.num_optional_named_parameters(); 629 int num_opt_named_params = function.NumOptionalNamedParameters();
630 const int num_params = 630 const int num_params =
631 num_fixed_params + num_opt_pos_params + num_opt_named_params; 631 num_fixed_params + num_opt_pos_params + num_opt_named_params;
632 int implicit_this_param_pos = is_native_instance_closure ? -1 : 0; 632 int implicit_this_param_pos = is_native_instance_closure ? -1 : 0;
633 ASSERT(parsed_function().first_parameter_index() == 633 ASSERT(parsed_function().first_parameter_index() ==
634 ParsedFunction::kFirstLocalSlotIndex + implicit_this_param_pos); 634 ParsedFunction::kFirstLocalSlotIndex + implicit_this_param_pos);
635 635
636 // Check that min_num_pos_args <= num_pos_args <= max_num_pos_args, 636 // Check that min_num_pos_args <= num_pos_args <= max_num_pos_args,
637 // where num_pos_args is the number of positional arguments passed in. 637 // where num_pos_args is the number of positional arguments passed in.
638 const int min_num_pos_args = num_fixed_params; 638 const int min_num_pos_args = num_fixed_params;
639 const int max_num_pos_args = num_fixed_params + num_opt_pos_params; 639 const int max_num_pos_args = num_fixed_params + num_opt_pos_params;
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
1366 void ParallelMoveResolver::Exchange(const Address& mem1, const Address& mem2) { 1366 void ParallelMoveResolver::Exchange(const Address& mem1, const Address& mem2) {
1367 __ Exchange(mem1, mem2); 1367 __ Exchange(mem1, mem2);
1368 } 1368 }
1369 1369
1370 1370
1371 #undef __ 1371 #undef __
1372 1372
1373 } // namespace dart 1373 } // namespace dart
1374 1374
1375 #endif // defined TARGET_ARCH_X64 1375 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_ia32.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698