Fix incorrect use of UnrefCustomCursor.

Fix incorrect use of UnrefCustomCursor.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156471

[mazda, 2012-09-12 18:20:10]

Could you review this change?

sadrul: cursor code
sky: OWNERS review for ui/

Thanks,

[sadrul, 2012-09-12 18:21:11]

Thanks for the quick fix! LGTM

[mazda, 2012-09-12 19:42:39]

Sadrul,
I updated the CL to check if platform_cursor_ is non-zero.
Could you take another look?

[sadrul, 2012-09-12 19:46:55]

http://codereview.chromium.org/10928154/diff/3002/ui/base/cursor/cursor_x11.cc
File ui/base/cursor/cursor_x11.cc (right):

http://codereview.chromium.org/10928154/diff/3002/ui/base/cursor/cursor_x11.c...
ui/base/cursor/cursor_x11.cc:13: ui::RefCustomXCursor(platform_cursor_);
Do you know where Ref/Unref is getting called but platform_cursor_ is null?

[mazda, 2012-09-12 19:56:43]

http://codereview.chromium.org/10928154/diff/3002/ui/base/cursor/cursor_x11.cc
File ui/base/cursor/cursor_x11.cc (right):

http://codereview.chromium.org/10928154/diff/3002/ui/base/cursor/cursor_x11.c...
ui/base/cursor/cursor_x11.cc:13: ui::RefCustomXCursor(platform_cursor_);
On 2012/09/12 19:46:56, sadrul wrote:
> Do you know where Ref/Unref is getting called but platform_cursor_ is null?
That's the following lines in webkit/glue/webcursor_aura.cc (line 102).

ui::Cursor cursor(ui::kCursorCustom);
cursor.SetPlatformCursor(GetPlatformCursor());

[sadrul, 2012-09-12 19:57:39]

Ah, I see. Thanks. LGTM

[sky, 2012-09-12 21:33:04]

LGTM

[commit-bot: I haz the power, 2012-09-12 21:36:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10928154/3002

[commit-bot: I haz the power, 2012-09-12 22:05:17]

Try job failure for 10928154-3002 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-09-13 00:25:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10928154/3002

[commit-bot: I haz the power, 2012-09-13 02:34:51]

Change committed as 156471