Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 10928152: Fix the warnings when compiling harfbuzz with clang in Android (Closed)

Created:
8 years, 3 months ago by michaelbai
Modified:
8 years, 3 months ago
Reviewers:
agl
CC:
chromium-reviews
Visibility:
Public.

Description

Fix the warnings when compiling harfbuzz with clang in Android, the warnings were: third_party/harfbuzz/contrib/harfbuzz-freetype.c:26:57: error: incompatible pointer types passing 'size_t *' (aka 'unsigned int *') to parameter of type 'ssize_t *' (aka 'long *') [-Werror,-Wincompatible-pointer-types] const uint32_t cp = utf16_to_code_point(chars, len, &i); ^~ third_party/harfbuzz/contrib/harfbuzz-unicode.h:22:74: note: passing argument to parameter 'iter' here uint32_t utf16_to_code_point(const uint16_t *chars, size_t len, ssize_t *iter); ^ third_party/harfbuzz/contrib/harfbuzz-freetype.c:58:57: error: incompatible pointer types passing 'size_t *' (aka 'unsigned int *') to parameter of type 'ssize_t *' (aka 'long *') [-Werror,-Wincompatible-pointer-types] const uint32_t cp = utf16_to_code_point(chars, len, &i); ^~ third_party/harfbuzz/contrib/harfbuzz-unicode.h:22:74: note: passing argument to parameter 'iter' here uint32_t utf16_to_code_point(const uint16_t *chars, size_t len, ssize_t *iter); BUG=143931 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156760

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -14 lines) Patch
M third_party/harfbuzz/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz/chromium.patch View 5 chunks +36 lines, -12 lines 0 comments Download
M third_party/harfbuzz/contrib/harfbuzz-freetype.c View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
michaelbai
8 years, 3 months ago (2012-09-12 17:55:53 UTC) #1
michaelbai
On 2012/09/12 17:55:53, michaelbai wrote: Ping
8 years, 3 months ago (2012-09-13 17:52:44 UTC) #2
agl
lgtm https://chromiumcodereview.appspot.com/10928152/diff/1/third_party/harfbuzz/contrib/harfbuzz-freetype.c File third_party/harfbuzz/contrib/harfbuzz-freetype.c (right): https://chromiumcodereview.appspot.com/10928152/diff/1/third_party/harfbuzz/contrib/harfbuzz-freetype.c#newcode26 third_party/harfbuzz/contrib/harfbuzz-freetype.c:26: while (i < len) { I fear that ...
8 years, 3 months ago (2012-09-13 17:59:03 UTC) #3
michaelbai
https://chromiumcodereview.appspot.com/10928152/diff/1/third_party/harfbuzz/contrib/harfbuzz-freetype.c File third_party/harfbuzz/contrib/harfbuzz-freetype.c (right): https://chromiumcodereview.appspot.com/10928152/diff/1/third_party/harfbuzz/contrib/harfbuzz-freetype.c#newcode26 third_party/harfbuzz/contrib/harfbuzz-freetype.c:26: while (i < len) { I didn't see the ...
8 years, 3 months ago (2012-09-13 18:23:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10928152/1
8 years, 3 months ago (2012-09-13 18:24:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10928152/7001
8 years, 3 months ago (2012-09-14 04:37:58 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-14 06:58:27 UTC) #7
Change committed as 156760

Powered by Google App Engine
This is Rietveld 408576698