Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: runtime/bin/dbg_connection.cc

Issue 10928149: Fix for http://code.google.com/p/dart/issues/detail?id=5085 - break-on-exceptions in the debugger c… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/include/dart_debugger_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dbg_connection.cc
===================================================================
--- runtime/bin/dbg_connection.cc (revision 12271)
+++ runtime/bin/dbg_connection.cc (working copy)
@@ -433,7 +433,21 @@
if (Dart_IsNull(object)) {
text = Dart_Null();
} else {
+ Dart_ExceptionPauseInfo savedState = Dart_GetExceptionPauseInfo();
+
+ // TODO(hausner): Check whether recursive/reentrant pauses on exceptions
+ // should be prevented in Debugger::SignalExceptionThrown() instead.
+ if (savedState != kNoPauseOnExceptions) {
+ Dart_Handle res = Dart_SetExceptionPauseInfo(kNoPauseOnExceptions);
+ ASSERT_NOT_ERROR(res);
+ }
+
text = Dart_ToString(object);
+
+ if (savedState != kNoPauseOnExceptions) {
+ Dart_Handle res = Dart_SetExceptionPauseInfo(savedState);
+ ASSERT_NOT_ERROR(res);
+ }
}
buf->Printf("\"text\":");
if (Dart_IsNull(text)) {
« no previous file with comments | « no previous file | runtime/include/dart_debugger_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698