Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4312)

Unified Diff: WebCore/bindings/dart/DartController.cpp

Issue 10928146: Update dart bindings to correctly patch print. (Closed) Base URL: http://src.chromium.org/multivm/trunk/webkit/Source/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/bindings/dart/DartController.cpp
===================================================================
--- WebCore/bindings/dart/DartController.cpp (revision 864)
+++ WebCore/bindings/dart/DartController.cpp (working copy)
@@ -74,10 +74,10 @@
Dart_Handle library = Dart_LookupLibrary(Dart_NewString(targetLibrary));
ASSERT(!Dart_IsError(library));
- Dart_Handle cls = Dart_GetClass(library, Dart_NewString(targetClass));
- ASSERT(!Dart_IsError(cls));
+ Dart_Handle target = targetClass ? Dart_GetClass(library, Dart_NewString(targetClass)) : library;
+ ASSERT(!Dart_IsError(target));
- Dart_SetField(cls, Dart_NewString(targetField), value);
+ Dart_SetField(target, Dart_NewString(targetField), value);
}
static void initDOMIsolate()
@@ -93,7 +93,7 @@
Dart_LibraryImportLibrary(core, html, Dart_Null());
// Setup configuration closures
- copyValue(html, "_printClosure", "dart:coreimpl", "PrintImplementation", "_printClosure");
+ copyValue(html, "_printClosure", "dart:core", 0, "_printClosure");
copyValue(html, "_timerFactoryClosure", "dart:isolate", "_TimerFactory", "_factory");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698