Update dart bindings to correctly patch print.

WebCore/bindings/dart/DartController.cpp

 // Copyright (c) 2009, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 56 matching lines @@
 
 static void copyValue(Dart_Handle source, const char* fieldName,
     const char* targetLibrary, const char* targetClass, const char* targetField)
 {
     Dart_Handle value = Dart_GetField(source, Dart_NewString(fieldName));
     ASSERT(!Dart_IsError(value));
 
     Dart_Handle library = Dart_LookupLibrary(Dart_NewString(targetLibrary));
     ASSERT(!Dart_IsError(library));
 
-    Dart_Handle cls = Dart_GetClass(library, Dart_NewString(targetClass));
-    ASSERT(!Dart_IsError(cls));
-
-    Dart_SetField(cls, Dart_NewString(targetField), value);
+    if (targetClass) {

[Anton Muhin, 2012/09/12 14:50:54]

Please, to keep the cases as similar as they can be, reword it like:

Dart_Handle target = targetClass ? Dart_GetClass(library, Dart_NewString(...) :
library;
ASSERT(!Dart_IsError(target));
Dart_SetField(target, Dart_NewString(...)))

[Mads Ager (google), 2012/09/13 07:17:42]

Done.

+      Dart_Handle cls = Dart_GetClass(library, Dart_NewString(targetClass));
+      ASSERT(!Dart_IsError(cls));
+      Dart_SetField(cls, Dart_NewString(targetField), value);

[Anton Muhin, 2012/09/12 14:50:54]

nit: 4 spaces for indent.

[Mads Ager (google), 2012/09/13 07:17:42]

Thanks. Code is now gone.

+    } else {
+      Dart_SetField(library, Dart_NewString(targetField), value);
+    }
 }
 
 static void initDOMIsolate()
 {
     // Fix the html library.
     Dart_Handle html = Dart_LookupLibrary(Dart_NewString(DartUtilities::htmlLibraryName));
     ASSERT(!Dart_IsError(html));
 
     Dart_SetNativeResolver(html, domResolver);
 
     // Import html library into core to make it all available to the user directly.
     Dart_Handle core = Dart_LookupLibrary(Dart_NewString("dart:core"));
     Dart_LibraryImportLibrary(core, html, Dart_Null());
 
     // Setup configuration closures
-    copyValue(html, "_printClosure", "dart:coreimpl", "PrintImplementation", "_printClosure");
+    copyValue(html, "_printClosure", "dart:core", 0, "_printClosure");

[Anton Muhin, 2012/09/12 14:50:54]

cannot we unify this stuff and use class for print configuration too?  or
migrate both to top-level fields?

[Mads Ager (google), 2012/09/13 07:17:42]

We could but I don't think we want to put that requirement on stuff that can be
patched from the embedder. I agree with you that we could probably make this
easier to handle for the embedder. Maybe by having some shared dart utility code
that contains something like your 'copyValue' method above and is used by all
embedders?

[Anton Muhin, 2012/09/13 07:25:33]

That'd be cool.

On 2012/09/13 07:17:42, Mads Ager wrote:

     copyValue(html, "_timerFactoryClosure", "dart:isolate", "_TimerFactory", "_factory");
 }
 
 static void messageNotifyCallback(Dart_Isolate);
 
 PassRefPtr<DartIsolate> DartController::createDOMIsolate(Document* document, PassRefPtr<DartApplicationLoader> applicationLoader)
 {
     RefPtr<DartIsolate> isolate = DartIsolate::create(document, applicationLoader);
 
     DartApiScope apiScope;
@@ skipping 495 matching lines @@
 }
 
 DartController* DartController::retrieve(ScriptExecutionContext* context)
 {
     if (!context || !context->isDocument())
         return 0;
     return retrieve(static_cast<Document*>(context)->frame());
 }
 
 }