Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 10928072: Remove all support for the Carbon NPAPI event model (Closed)

Created:
8 years, 3 months ago by stuartmorgan
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@test-plugin-cocoa
Visibility:
Public.

Description

Remove all support for the Carbon NPAPI event model Plugins already cannot negotiate the Carbon event model; this removes all the code supporting the Carbon model now that it is no longer necessary. The interpose library is left in place because plugins that use the Cocoa event model may still make Carbon OS calls for window or cursor managament. BUG=125915 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156102

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -826 lines) Patch
M chrome/app/framework.order View 1 chunk +0 lines, -10 lines 0 comments Download
M content/common/plugin_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/plugin/plugin_carbon_interpose_mac.cc View 7 chunks +0 lines, -46 lines 0 comments Download
M content/plugin/plugin_interpose_util_mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/plugin/plugin_interpose_util_mac.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 1 chunk +1 line, -9 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/plugins/npapi/carbon_plugin_window_tracker_mac.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webkit/plugins/npapi/carbon_plugin_window_tracker_mac.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M webkit/plugins/npapi/plugin_web_event_converter_mac.h View 1 chunk +14 lines, -24 lines 0 comments Download
M webkit/plugins/npapi/plugin_web_event_converter_mac.mm View 6 chunks +36 lines, -211 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 3 chunks +0 lines, -22 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 18 chunks +47 lines, -362 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
stuartmorgan
Note that I don't actually think we should keep supporting the Carbon cursor interposing, since ...
8 years, 3 months ago (2012-09-09 16:29:12 UTC) #1
Avi (use Gerrit)
lgtm
8 years, 3 months ago (2012-09-09 23:01:57 UTC) #2
stuartmorgan
+brettw for owners
8 years, 3 months ago (2012-09-10 07:26:55 UTC) #3
brettw
owners lgtm mostly-rubberstamp
8 years, 3 months ago (2012-09-10 23:47:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10928072/1
8 years, 3 months ago (2012-09-11 07:43:24 UTC) #5
commit-bot: I haz the power
Failed to apply patch for webkit/plugins/npapi/webplugin_delegate_impl_mac.mm: While running patch -p1 --forward --force; patching file webkit/plugins/npapi/webplugin_delegate_impl_mac.mm ...
8 years, 3 months ago (2012-09-11 07:43:27 UTC) #6
stuartmorgan
Whoops, the other patch hasn't landed yet.
8 years, 3 months ago (2012-09-11 07:44:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10928072/7001
8 years, 3 months ago (2012-09-11 17:47:22 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 19:47:20 UTC) #9
Change committed as 156102

Powered by Google App Engine
This is Rietveld 408576698