Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/browser/resources/help/help.js

Issue 10928061: About page UI: add confirmation message for release channel switch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix help.js indentation as suggested by jhawkins. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/help/help.html ('k') | chrome/browser/ui/webui/help/help_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/help/help.js
diff --git a/chrome/browser/resources/help/help.js b/chrome/browser/resources/help/help.js
index a6bbf3333f8986d93fab5aa4ac2ee9350f248e29..983b2fa381ed3c59f556953b1ec734960d2e1d96 100644
--- a/chrome/browser/resources/help/help.js
+++ b/chrome/browser/resources/help/help.js
@@ -54,6 +54,11 @@ cr.define('help', function() {
var channelChanger = $('channel-changer');
if (channelChanger) {
+ this.channelName_ = {
+ 'stable-channel': loadTimeData.getString('stable'),
+ 'beta-channel': loadTimeData.getString('beta'),
+ 'dev-channel': loadTimeData.getString('dev')
+ };
var self = this;
channelChanger.onchange = function(event) {
self.setReleaseChannel_(event.target.value);
@@ -215,6 +220,9 @@ cr.define('help', function() {
*/
setReleaseChannel_: function(channel) {
chrome.send('setReleaseTrack', [channel]);
+ $('channel-change-confirmation').hidden = false;
+ $('channel-change-confirmation').textContent = loadTimeData.getStringF(
+ 'channel-changed', this.channelName_[channel]);
},
/**
« no previous file with comments | « chrome/browser/resources/help/help.html ('k') | chrome/browser/ui/webui/help/help_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698