About page UI: add confirmation message for release channel switch.

About page UI: add confirmation message for release channel switch.

As suggested by joshwoodwards@:
a) Move updating status above "more info" section so it isn't pushed to the bottom of the page;
b) Once a user switches channels, a confirmation message should appear just below the drop-down.

BUG=139622
TEST=lumpy


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155706

[hshi1, 2012-09-07 21:15:07]

UI change based on Josh's mockup:
http://code.google.com/p/chromium/issues/detail?id=139622#c8

Please take a look,thanks!

[hshi1, 2012-09-07 21:27:25]

+xiyuan also to review the UI change, thanks!

[xiyuan, 2012-09-07 22:02:56]

lgtm

http://codereview.chromium.org/10928061/diff/2002/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10928061/diff/2002/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9389: +        You have switched to the <ph
name="CHANNEL_NAME">$1<ex>Stable</ex></ph> channel
nit: "." at the end.

[hshi1, 2012-09-07 22:05:20]

http://codereview.chromium.org/10928061/diff/2002/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10928061/diff/2002/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9389: +        You have switched to the <ph
name="CHANNEL_NAME">$1<ex>Stable</ex></ph> channel
On 2012/09/07 22:02:56, xiyuan wrote:
> nit: "." at the end.

Done.

[hshi1, 2012-09-07 23:11:36]

I just realized that generated_resources.grd owner is *. Adding csilv@ who's on
the owners list for both chrome/browser/resources and chrome/browser/ui/webui.

Thanks!

[James Hawkins, 2012-09-09 18:08:29]

http://codereview.chromium.org/10928061/diff/6010/chrome/browser/resources/he...
File chrome/browser/resources/help/help.html (right):

http://codereview.chromium.org/10928061/diff/6010/chrome/browser/resources/he...
chrome/browser/resources/help/help.html:41: <if expr="pp_ifdef('chromeos') or
pp_ifdef('_google_chrome') or is_linux">
Why is this moved?

http://codereview.chromium.org/10928061/diff/6010/chrome/browser/resources/he...
File chrome/browser/resources/help/help.js (right):

http://codereview.chromium.org/10928061/diff/6010/chrome/browser/resources/he...
chrome/browser/resources/help/help.js:225:
loadTimeData.getStringF('channel-changed', this.channelName_[channel]);
nit: Indentation should be two more spaces.

[hshi1, 2012-09-10 03:58:31]

http://codereview.chromium.org/10928061/diff/6010/chrome/browser/resources/he...
File chrome/browser/resources/help/help.html (right):

http://codereview.chromium.org/10928061/diff/6010/chrome/browser/resources/he...
chrome/browser/resources/help/help.html:41: <if expr="pp_ifdef('chromeos') or
pp_ifdef('_google_chrome') or is_linux">
On 2012/09/09 18:08:29, James Hawkins wrote:
> Why is this moved?

This is suggested by Josh Woodward in
(http://code.google.com/p/chromium/issues/detail?id=139622#c8) item a): move the
status update container to above the "more info" section -- so that when the
more info section is expanded to show the channel changer, it would not push the
update status down (and usually out of view).

[James Hawkins, 2012-09-10 04:00:02]

lgtm

[hshi1, 2012-09-10 06:16:57]

http://codereview.chromium.org/10928061/diff/6010/chrome/browser/resources/he...
File chrome/browser/resources/help/help.js (right):

http://codereview.chromium.org/10928061/diff/6010/chrome/browser/resources/he...
chrome/browser/resources/help/help.js:225:
loadTimeData.getStringF('channel-changed', this.channelName_[channel]);
On 2012/09/09 18:08:29, James Hawkins wrote:
> nit: Indentation should be two more spaces.

Done.

[commit-bot: I haz the power, 2012-09-10 06:52:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/10928061/12

[commit-bot: I haz the power, 2012-09-10 11:26:57]

Change committed as 155706