Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 10928051: Remove more () from getters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/string_base.dart ('k') | runtime/vm/object_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index 0f1435746fc262fcc50fede506346957fbf5def6..511ef579d0613f49cb6eae1bccf6b271bb07d77f 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -2548,16 +2548,16 @@ TEST_CASE(FieldAccess) {
" static const const_static_fld = 'const static';\n"
" static const _const_static_fld = 'hidden const static';\n"
"\n"
- " get instance_getset_fld() { return _gs_fld1; }\n"
+ " get instance_getset_fld { return _gs_fld1; }\n"
" void set instance_getset_fld(var value) { _gs_fld1 = value; }\n"
- " get _instance_getset_fld() { return _gs_fld2; }\n"
+ " get _instance_getset_fld { return _gs_fld2; }\n"
" void set _instance_getset_fld(var value) { _gs_fld2 = value; }\n"
" var _gs_fld1;\n"
" var _gs_fld2;\n"
"\n"
- " static get static_getset_fld() { return _gs_fld3; }\n"
+ " static get static_getset_fld { return _gs_fld3; }\n"
" static void set static_getset_fld(var value) { _gs_fld3 = value; }\n"
- " static get _static_getset_fld() { return _gs_fld4; }\n"
+ " static get _static_getset_fld { return _gs_fld4; }\n"
" static void set _static_getset_fld(var value) { _gs_fld4 = value; }\n"
" static var _gs_fld3;\n"
" static var _gs_fld4;\n"
@@ -2567,9 +2567,9 @@ TEST_CASE(FieldAccess) {
"const const_top_fld = 'const top';\n"
"const _const_top_fld = 'hidden const top';\n"
"\n"
- "get top_getset_fld() { return _gs_fld5; }\n"
+ "get top_getset_fld { return _gs_fld5; }\n"
"void set top_getset_fld(var value) { _gs_fld5 = value; }\n"
- "get _top_getset_fld() { return _gs_fld6; }\n"
+ "get _top_getset_fld { return _gs_fld6; }\n"
"void set _top_getset_fld(var value) { _gs_fld6 = value; }\n"
"var _gs_fld5;\n"
"var _gs_fld6;\n"
@@ -2586,9 +2586,9 @@ TEST_CASE(FieldAccess) {
"#library('library_name');\n"
"var imported_fld = 'imported';\n"
"var _imported_fld = 'hidden imported';\n"
- "get imported_getset_fld() { return _gs_fld1; }\n"
+ "get imported_getset_fld { return _gs_fld1; }\n"
"void set imported_getset_fld(var value) { _gs_fld1 = value; }\n"
- "get _imported_getset_fld() { return _gs_fld2; }\n"
+ "get _imported_getset_fld { return _gs_fld2; }\n"
"void set _imported_getset_fld(var value) { _gs_fld2 = value; }\n"
"var _gs_fld1;\n"
"var _gs_fld2;\n"
@@ -4138,30 +4138,30 @@ TEST_CASE(FunctionReflection) {
const char* kScriptChars =
"a() => 'a';\n"
"_b() => '_b';\n"
- "get c() => 'bar';\n"
+ "get c => 'bar';\n"
"set d(x) {}\n"
- "get _e() => 'bar';\n"
+ "get _e => 'bar';\n"
"set _f(x) {}\n"
"class MyClass {\n"
" MyClass() {}\n"
" MyClass.named() {}\n"
" a() => 'a';\n"
" _b() => '_b';\n"
- " get c() => 'bar';\n"
+ " get c => 'bar';\n"
" set d(x) {}\n"
- " get _e() => 'bar';\n"
+ " get _e => 'bar';\n"
" set _f(x) {}\n"
" static g() => 'g';\n"
" static _h() => '_h';\n"
- " static get i() => 'i';\n"
+ " static get i => 'i';\n"
" static set j(x) {}\n"
- " static get _k() => 'k';\n"
+ " static get _k => 'k';\n"
" static set _l(x) {}\n"
" abstract m();\n"
" abstract _n();\n"
- " abstract get o();\n"
+ " abstract get o;\n"
" abstract set p(x);\n"
- " abstract get _q();\n"
+ " abstract get _q;\n"
" abstract set _r(x);\n"
" s(x, [y, z]) {}\n"
" t([x, y, z]) {}\n"
@@ -5027,21 +5027,21 @@ TEST_CASE(GetFunctionNames) {
"#library('library_name');\n"
"\n"
"void A() {}\n"
- "get B() => 11;\n"
+ "get B => 11;\n"
"set C(x) { }\n"
"var D;\n"
"void _A() {}\n"
- "get _B() => 11;\n"
+ "get _B => 11;\n"
"set _C(x) { }\n"
"var _D;\n"
"\n"
"class MyClass {\n"
" void A2() {}\n"
- " get B2() => 11;\n"
+ " get B2 => 11;\n"
" set C2(x) { }\n"
" var D2;\n"
" void _A2() {}\n"
- " get _B2() => 11;\n"
+ " get _B2 => 11;\n"
" set _C2(x) { }\n"
" var _D2;\n"
"}\n"
@@ -5097,11 +5097,11 @@ TEST_CASE(GetVariableNames) {
"#library('library_name');\n"
"\n"
"var A;\n"
- "get B() => 12;\n"
+ "get B => 12;\n"
"set C(x) { }\n"
"D(x) => (x + 1);\n"
"var _A;\n"
- "get _B() => 12;\n"
+ "get _B => 12;\n"
"set _C(x) { }\n"
"_D(x) => (x + 1);\n"
"\n"
@@ -5453,18 +5453,18 @@ TEST_CASE(ParsePatchLibrary) {
" var _f;\n"
" callFunc(x, y) => x(y);\n"
" external method(var value);\n"
- " get field() => _field;\n"
+ " get field => _field;\n"
"}\n"
"external int unpatched();\n"
"external int topLevel(var value);\n"
- "external int get topLevelGetter();\n"
+ "external int get topLevelGetter;\n"
"external void set topLevelSetter(int value);\n";
const char* kPatchChars =
"patch class A {\n"
" var _g;\n"
" A() : fvalue = 13;\n"
- " get _field() => _g;\n"
+ " get _field => _g;\n"
" patch method(var value) {\n"
" int closeYourEyes(var eggs) { return eggs * -1; }\n"
" value = callFunc(closeYourEyes, value);\n"
@@ -5474,7 +5474,7 @@ TEST_CASE(ParsePatchLibrary) {
"var _topLevelValue = -1;\n"
"patch int topLevel(var value) => value * value;\n"
"patch int set topLevelSetter(value) { _topLevelValue = value; }\n"
- "patch int get topLevelGetter() => 2 * _topLevelValue;\n"
+ "patch int get topLevelGetter => 2 * _topLevelValue;\n"
// Allow top level methods named patch.
"patch(x) => x*3;\n";
« no previous file with comments | « runtime/lib/string_base.dart ('k') | runtime/vm/object_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698