chrome/common/nacl_types.cc - Issue 10928050: Open socket for NaCl GDB debug stub in browser process.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/nacl_types.cc

Issue 10928050: Open socket for NaCl GDB debug stub in browser process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/nacl_types.h"	5 #include "chrome/common/nacl_types.h"

	6 #include "net/base/tcp_listen_socket.h"
	Mark Seaborn 2012/09/10 15:39:45 You don't need to add this, do you? You don't need to add this, do you? halyavin 2012/09/11 11:16:12 Done. Show quoted text On 2012/09/10 15:39:45, Mark Seaborn wrote: > You don't need to add this, do you? Done.
6	7

7 namespace nacl {	8 namespace nacl {

8	9

9 NaClStartParams::NaClStartParams()	10 NaClStartParams::NaClStartParams()

10 : validation_cache_enabled(false),	11 : validation_cache_enabled(false),

11 enable_exception_handling(false) {	12 enable_exception_handling(false) {

	13
	Mark Seaborn 2012/09/10 15:39:45 Nit: don't add an empty line here Nit: don't add an empty line here halyavin 2012/09/11 11:16:12 Done. Show quoted text On 2012/09/10 15:39:45, Mark Seaborn wrote: > Nit: don't add an empty line here Done.
12 }	14 }

13	15

14 NaClStartParams::~NaClStartParams() {	16 NaClStartParams::~NaClStartParams() {

15 }	17 }

16	18

17 } // namespace nacl	19 } // namespace nacl

OLD	NEW