Open socket for NaCl GDB debug stub in browser process.

chrome/browser/nacl_host/nacl_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_
 #define CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_
 
 #include "build/build_config.h"
 
 #include "base/file_path.h"
@@ skipping 73 matching lines @@
   };
 
 #if defined(OS_WIN)
   // Create command line for launching loader under nacl-gdb.
   scoped_ptr<CommandLine> GetCommandForLaunchWithGdb(const FilePath& nacl_gdb,
                                                      CommandLine* line);
 #elif defined(OS_LINUX)
   bool LaunchNaClGdb(base::ProcessId pid);
   void OnNaClGdbAttached();
 #endif
+#if defined(OS_POSIX)
+  // Create socket for debug stub in browser process so that we can leave
+  // sandbox turned on during debugging.

[Mark Seaborn, 2012/09/10 15:39:45]

Please disambiguate "debugging" in comments so that it's clear to readers that
you're referring to the GDB debug stub.

Maybe: "Create bound TCP socket in the browser process so that the GDB debug
stub will work when the Chrome sandbox is enabled."

[halyavin, 2012/09/11 11:16:12]

Done.

+  SocketDescriptor GetDebugStubSocketHandle();
+#endif
   // Get path to manifest on local disk if possible.
   FilePath GetManifestPath();
   bool LaunchSelLdr();
 
   // BrowserChildProcessHostDelegate implementation:
   virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
   virtual void OnProcessLaunched() OVERRIDE;
 
   void OnResourcesReady();
 
@@ skipping 78 matching lines @@
 
   // Channel proxy to terminate the NaCl-Browser PPAPI channel.
   scoped_ptr<IPC::ChannelProxy> ipc_proxy_channel_;
   // Plugin listener, to forward browser channel messages to us.
   PluginListener ipc_plugin_listener_;
 
   DISALLOW_COPY_AND_ASSIGN(NaClProcessHost);
 };
 
 #endif  // CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_