Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 109223007: GTTF: Make runtest.py use the new test launcher's JSON summary. (Closed)

Created:
7 years ago by Paweł Hajdan Jr.
Modified:
7 years ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

GTTF: Make runtest.py use the new test launcher's JSON summary. BUG=236893 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=241531

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -26 lines) Patch
M scripts/common/gtest_utils.py View 1 2 3 4 2 chunks +93 lines, -0 lines 0 comments Download
M scripts/common/unittests/gtest_utils_test.py View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
M scripts/slave/runtest.py View 1 2 15 chunks +59 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
7 years ago (2013-12-13 23:48:03 UTC) #1
ghost stip (do not use)
This is a really good surgical change, thanks for cleaning this up a lot. Do ...
7 years ago (2013-12-16 21:18:50 UTC) #2
Paweł Hajdan Jr.
Tests added. Please take another look and avoid adding unnecessary round-trips in review. :) https://codereview.chromium.org/109223007/diff/60001/scripts/common/gtest_utils.py ...
7 years ago (2013-12-17 16:51:56 UTC) #3
ghost stip (do not use)
lgtm https://codereview.chromium.org/109223007/diff/60001/scripts/slave/runtest.py File scripts/slave/runtest.py (right): https://codereview.chromium.org/109223007/diff/60001/scripts/slave/runtest.py#newcode196 scripts/slave/runtest.py:196: if using_gtest_json(options): On 2013/12/17 16:51:56, Paweł Hajdan Jr. ...
7 years ago (2013-12-17 18:36:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/109223007/80001
7 years ago (2013-12-18 09:06:26 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-18 09:07:13 UTC) #6
Message was sent while issue was closed.
Change committed as 241531

Powered by Google App Engine
This is Rietveld 408576698