GTTF: Make runtest.py use the new test launcher's JSON summary.

GTTF: Make runtest.py use the new test launcher's JSON summary.

BUG=236893
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=241531

[ghost stip (do not use), 2013-12-16 21:18:50]

This is a really good surgical change, thanks for cleaning this up a lot. Do you
mind if we add some test coverage? Take a look at
scripts/common/unittests/gtest_utils_test.py

https://chromiumcodereview.appspot.com/109223007/diff/60001/scripts/common/gt...
File scripts/common/gtest_utils.py (right):

https://chromiumcodereview.appspot.com/109223007/diff/60001/scripts/common/gt...
scripts/common/gtest_utils.py:458: json_data = json.loads(json_output)
I'm assuming you're not using json.load() because you also want to capture the
file in case of parsing errors?

https://chromiumcodereview.appspot.com/109223007/diff/60001/scripts/common/gt...
scripts/common/gtest_utils.py:461: else:
didn't know you could do that

https://chromiumcodereview.appspot.com/109223007/diff/60001/scripts/common/gt...
scripts/common/gtest_utils.py:473: self.test_logs[test_name] = []
remove line 472, make this self.test_logs.setdefault(test_name, [])

you could also make test_logs a defaultdict

https://chromiumcodereview.appspot.com/109223007/diff/60001/scripts/slave/run...
File scripts/slave/runtest.py (right):

https://chromiumcodereview.appspot.com/109223007/diff/60001/scripts/slave/run...
scripts/slave/runtest.py:196: if using_gtest_json(options):
don't you still need the XML reader here for the flakiness dashboard?

[Paweł Hajdan Jr., 2013-12-17 16:51:56]

Tests added. Please take another look and avoid adding unnecessary round-trips
in review. :)

https://codereview.chromium.org/109223007/diff/60001/scripts/common/gtest_uti...
File scripts/common/gtest_utils.py (right):

https://codereview.chromium.org/109223007/diff/60001/scripts/common/gtest_uti...
scripts/common/gtest_utils.py:458: json_data = json.loads(json_output)
On 2013/12/16 21:18:50, stip wrote:
> I'm assuming you're not using json.load() because you also want to capture the
> file in case of parsing errors?

Yes.

https://codereview.chromium.org/109223007/diff/60001/scripts/common/gtest_uti...
scripts/common/gtest_utils.py:473: self.test_logs[test_name] = []
On 2013/12/16 21:18:50, stip wrote:
> remove line 472, make this self.test_logs.setdefault(test_name, [])
> 
> you could also make test_logs a defaultdict

Done.

https://codereview.chromium.org/109223007/diff/60001/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

https://codereview.chromium.org/109223007/diff/60001/scripts/slave/runtest.py...
scripts/slave/runtest.py:196: if using_gtest_json(options):
On 2013/12/16 21:18:50, stip wrote:
> don't you still need the XML reader here for the flakiness dashboard?

Sorry, could you explain more? We discussed this offline - data for
test-results.appspot.com is generated based on the JSON summary, not on the
gtest XML file we don't have here.

[ghost stip (do not use), 2013-12-17 18:36:39]

lgtm

https://codereview.chromium.org/109223007/diff/60001/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

https://codereview.chromium.org/109223007/diff/60001/scripts/slave/runtest.py...
scripts/slave/runtest.py:196: if using_gtest_json(options):
On 2013/12/17 16:51:56, Paweł Hajdan Jr. wrote:
> On 2013/12/16 21:18:50, stip wrote:
> > don't you still need the XML reader here for the flakiness dashboard?
> 
> Sorry, could you explain more? We discussed this offline - data for
> http://test-results.appspot.com is generated based on the JSON summary, not on
the
> gtest XML file we don't have here.

ah sorry, I misread the if indentation and thought you weren't setting
results_map. it looks like line 204 fires though

[commit-bot: I haz the power, 2013-12-18 09:06:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/109223007/80001

[commit-bot: I haz the power, 2013-12-18 09:07:13]

Change committed as 241531