Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3025)

Unified Diff: build/android/envsetup.sh

Issue 10920094: android: Refine ANDROID_SDK_ROOT definition for SDK builds. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/envsetup_functions.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/envsetup.sh
diff --git a/build/android/envsetup.sh b/build/android/envsetup.sh
index b0024858d70492f11ba2de8a541d7c71341a9f03..1d13acd84ba7a6b8f375c5dce92f83e46ebc8bdd 100755
--- a/build/android/envsetup.sh
+++ b/build/android/envsetup.sh
@@ -40,12 +40,12 @@ case "${host_os}" in
esac
CURRENT_DIR="$(readlink -f "$(dirname $BASH_SOURCE)/../../")"
-if [ -z "${CHROME_SRC}" ]; then
+if [[ -z "${CHROME_SRC}" ]]; then
# If $CHROME_SRC was not set, assume current directory is CHROME_SRC.
export CHROME_SRC="${CURRENT_DIR}"
fi
-if [ "${CURRENT_DIR/"${CHROME_SRC}"/}" == "${CURRENT_DIR}" ]; then
+if [[ "${CURRENT_DIR/"${CHROME_SRC}"/}" == "${CURRENT_DIR}" ]]; then
# If current directory is not in $CHROME_SRC, it might be set for other
# source tree. If $CHROME_SRC was set correctly and we are in the correct
# directory, "${CURRENT_DIR/"${CHROME_SRC}"/}" will be "".
@@ -61,12 +61,13 @@ export ANDROID_SDK_VERSION=16
# Source functions script. The file is in the same directory as this script.
. "$(dirname $BASH_SOURCE)"/envsetup_functions.sh
-if [ "${ANDROID_SDK_BUILD}" -eq 1 ]; then
+if [[ "${ANDROID_SDK_BUILD}" -eq 1 ]]; then
sdk_build_init
# Sets up environment for building Chromium for Android with source. Expects
# android environment setup and lunch.
-elif [ -z "$ANDROID_BUILD_TOP" -o -z "$ANDROID_TOOLCHAIN" -o \
- -z "$ANDROID_PRODUCT_OUT" ]; then
+elif [[ -z "$ANDROID_BUILD_TOP" || \
+ -z "$ANDROID_TOOLCHAIN" || \
+ -z "$ANDROID_PRODUCT_OUT" ]]; then
echo "Android build environment variables must be set."
echo "Please cd to the root of your Android tree and do: "
echo " . build/envsetup.sh"
@@ -79,7 +80,7 @@ else
fi
# Workaround for valgrind build
-if [ -n "$CHROME_ANDROID_VALGRIND_BUILD" ]; then
+if [[ -n "$CHROME_ANDROID_VALGRIND_BUILD" ]]; then
# arm_thumb=0 is a workaround for https://bugs.kde.org/show_bug.cgi?id=270709
DEFINES+=" arm_thumb=0 release_extra_cflags='-fno-inline\
-fno-omit-frame-pointer -fno-builtin' release_valgrind_build=1\
« no previous file with comments | « no previous file | build/android/envsetup_functions.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698