lib/compiler/implementation/typechecker.dart - Issue 10920089: Generate a warning and a runtime error for calls to nonexistent static calls, getters and setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/typechecker.dart

Issue 10920089: Generate a warning and a runtime error for calls to nonexistent static calls, getters and setters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove case for variable == null in handling of ForIn. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/compiler/implementation/ssa/builder.dart ('K') | « lib/compiler/implementation/ssa/builder.dart ('k') | tests/language/call_nonexistent_static_test.dart » ('j') | tests/language/getter_no_setter2_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/typechecker.dart

diff --git a/lib/compiler/implementation/typechecker.dart b/lib/compiler/implementation/typechecker.dart

index fc82c88311e9514d7b9eadbbafb61a800efa1a99..c189a27093a381d0d7f9ef4fa409460777379529 100644

--- a/lib/compiler/implementation/typechecker.dart

+++ b/lib/compiler/implementation/typechecker.dart

@@ -573,7 +573,7 @@ class TypeCheckerVisitor implements Visitor<DartType> {

if (memberType.element === compiler.dynamicClass) return null;

return memberType;

} else {

- if (element === null) {

+ if (Element.isInvalid(element)) {

fail(node, 'unresolved ${node.selector}');

} else if (element.kind === ElementKind.FUNCTION) {

return computeType(element);