Generate a warning and a runtime error for calls to nonexistent static calls, getters and setters.

lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('elements');
 
 #import('dart:uri');
 
 #import('../tree/tree.dart');
 #import('../scanner/scannerlib.dart');
@@ skipping 277 matching lines @@
   bool isNative() => _isNative;
 
   FunctionElement asFunctionElement() => null;
 
   Element cloneTo(Element enclosing, DiagnosticListener listener) {
     listener.cancel("Unimplemented cloneTo", element: this);
   }
 
   bool get isPatched => false;
 
-  static bool isInvalid(Element e) => e == null || e.isErroneous();
+  static bool isUnresolved(Element e) => e == null || e.isErroneous();
+  static bool isErroneousElement(Element e) => e != null && e.isErroneous();

[ngeoffray, 2012/09/07 08:12:46]

Why aren't these methods on Element*s* class?

[karlklose, 2012/09/07 09:24:01]

Done, moved. I thought it reads better, but it is more consistent to have them
on Elements.

 }
 
 /**
  * Represents an unresolvable or duplicated element.
  *
  * An [ErroneousElement] is used instead of [null] to provide additional
  * information about the error that caused the element to be unresolvable
  * or otherwise invalid.
  *
  * Accessing any field or calling any method defined on [ErroneousElement]
  * except [isErroneous] will currently throw an exception. (This might
  * change when we actually want more information on the erroneous element,
  * e.g., the name of the element we were trying to resolve.)
  *
  * Code that cannot not handle an [ErroneousElement] should use
  *   [: Element.isInvalid(element) :]
  * to check for unresolvable elements instead of
  *   [: element == null :].
  */
 class ErroneousElement extends Element {
   final Message errorMessage;
+  final SourceString targetName;
 
-  ErroneousElement(this.errorMessage, Element enclosing)
+  ErroneousElement(this.errorMessage, this.targetName, Element enclosing)
       : super(const SourceString('erroneous element'), null, enclosing);
 
   isErroneous() => true;
 
   unsupported() {
     throw 'unsupported operation on erroneous element';
   }
 
   SourceString get name => unsupported();
   ElementKind get kind => unsupported();
   Link<MetadataAnnotation> get metadata => unsupported();
+
+  getLibrary() => enclosingElement.getLibrary();
 }
 
 class ErroneousFunctionElement extends ErroneousElement
                                implements FunctionElement {
-  ErroneousFunctionElement(errorMessage, Element enclosing)
-      : super(errorMessage, enclosing);
+  ErroneousFunctionElement(Message errorMessage, SourceString targetName,
+                           Element enclosing)
+      : super(errorMessage, targetName, enclosing);
 
   get type => unsupported();
   get cachedNode => unsupported();
   get functionSignature => unsupported();
   get patch => unsupported();
   get defaultImplementation => unsupported();
   bool get isPatched => unsupported();
   setPatch(patch) => unsupported();
   computeSignature(compiler) => unsupported();
   requiredParameterCount(compiler) => unsupported();
   optionalParameterCount(compiler) => unsupported();
   parameterCount(copmiler) => unsupported();
-
-  getLibrary() => enclosingElement.getLibrary();
 }
 
 class ContainerElement extends Element {
   Link<Element> localMembers = const EmptyLink<Element>();
 
   ContainerElement(name, kind, enclosingElement)
     : super(name, kind, enclosingElement);
 
   void addMember(Element element, DiagnosticListener listener) {
     localMembers = localMembers.prepend(element);
@@ skipping 1016 matching lines @@
     listener.internalErrorOnElement(this, 'unsupported operation');
   }
 
   Link<DartType> get allSupertypesAndSelf {
     return allSupertypes.prepend(new InterfaceType(this));
   }
 }
 
 class Elements {
   static bool isLocal(Element element) {
-    return !Element.isInvalid(element)
+    return !Element.isUnresolved(element)
             && !element.isInstanceMember()
             && !isStaticOrTopLevelField(element)
             && !isStaticOrTopLevelFunction(element)
             && (element.kind === ElementKind.VARIABLE ||
                 element.kind === ElementKind.PARAMETER ||
                 element.kind === ElementKind.FUNCTION);
   }
 
   static bool isInstanceField(Element element) {
-    return !Element.isInvalid(element)
+    return !Element.isUnresolved(element)
            && element.isInstanceMember()
            && (element.kind === ElementKind.FIELD
                || element.kind === ElementKind.GETTER
                || element.kind === ElementKind.SETTER);
   }
 
   static bool isStaticOrTopLevel(Element element) {
     // TODO(ager): This should not be necessary when patch support has
     // been reworked.
-    if (!Element.isInvalid(element)
+    if (!Element.isUnresolved(element)
         && element.modifiers != null
         && element.modifiers.isStatic()) {
       return true;
     }
-    return !Element.isInvalid(element)
+    return !Element.isUnresolved(element)
            && !element.isInstanceMember()
            && !element.isPrefix()
            && element.enclosingElement !== null
            && (element.enclosingElement.kind == ElementKind.CLASS ||
                element.enclosingElement.kind == ElementKind.COMPILATION_UNIT ||
                element.enclosingElement.kind == ElementKind.LIBRARY);
   }
 
   static bool isStaticOrTopLevelField(Element element) {
     return isStaticOrTopLevel(element)
            && (element.kind === ElementKind.FIELD
                || element.kind === ElementKind.GETTER
                || element.kind === ElementKind.SETTER);
   }
 
   static bool isStaticOrTopLevelFunction(Element element) {
     return isStaticOrTopLevel(element)
            && (element.kind === ElementKind.FUNCTION);
   }
 
   static bool isInstanceMethod(Element element) {
-    return !Element.isInvalid(element)
+    return !Element.isUnresolved(element)
            && element.isInstanceMember()
            && (element.kind === ElementKind.FUNCTION);
   }
 
   static bool isInstanceSend(Send send, TreeElements elements) {
     Element element = elements[send];
     if (element === null) return !isClosureSend(send, element);
     return isInstanceMethod(element) || isInstanceField(element);
   }
 
@@ skipping 205 matching lines @@
 
   MetadataAnnotation ensureResolved(Compiler compiler) {
     if (resolutionState == STATE_NOT_STARTED) {
       compiler.resolver.resolveMetadataAnnotation(this);
     }
     return this;
   }
 
   String toString() => 'MetadataAnnotation($value, $resolutionState)';
 }