Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/browser/policy/device_management_service.cc

Issue 10920088: Always log the exact error code from the dmserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/device_management_service.cc
diff --git a/chrome/browser/policy/device_management_service.cc b/chrome/browser/policy/device_management_service.cc
index aebc8a62dc23dcf3e114039c7c2ce121c594fd17..c985447bd60289fc57d35ae58f91a6309c8e4b04 100644
--- a/chrome/browser/policy/device_management_service.cc
+++ b/chrome/browser/policy/device_management_service.cc
@@ -320,6 +320,9 @@ void DeviceManagementRequestJobImpl::HandleResponse(
return;
}
+ if (response_code != kSuccess)
+ LOG(WARNING) << "DMServer sent an error response: " << response_code;
+
switch (response_code) {
case kSuccess: {
em::DeviceManagementResponse response;
@@ -363,8 +366,6 @@ void DeviceManagementRequestJobImpl::HandleResponse(
ReportError(DM_STATUS_SERVICE_DEVICE_ID_CONFLICT);
return;
default:
- VLOG(1) << "Unexpected HTTP status in response from DMServer : "
- << response_code << ".";
// Handle all unknown 5xx HTTP error codes as temporary and any other
// unknown error as one that needs more time to recover.
if (response_code >= 500 && response_code <= 599)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698