Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: webkit/fileapi/isolated_file_util_unittest.cc

Issue 10920087: Update callers of CreateFileSystemOperation so more detailed error codes can be returned. Where app… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile error Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/fileapi/file_system_url_request_job.cc ('k') | webkit/fileapi/local_file_system_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/isolated_file_util_unittest.cc
diff --git a/webkit/fileapi/isolated_file_util_unittest.cc b/webkit/fileapi/isolated_file_util_unittest.cc
index 03953c87dcb83fc5f11c395967ec694134c5a12b..f6ddaadcf480e5dcf6f9d71226b795cad80362e5 100644
--- a/webkit/fileapi/isolated_file_util_unittest.cc
+++ b/webkit/fileapi/isolated_file_util_unittest.cc
@@ -304,7 +304,11 @@ TEST_F(IsolatedFileUtilTest, UnregisteredPathsTest) {
ASSERT_FALSE(url.is_valid());
// We should not be able to create a new operation for an invalid URL.
- ASSERT_EQ(NULL, file_system_context()->CreateFileSystemOperation(url));
+ base::PlatformFileError error_code;
+ FileSystemOperation* operation =
+ file_system_context()->CreateFileSystemOperation(url, &error_code);
+ ASSERT_EQ(NULL, operation);
+ ASSERT_EQ(base::PLATFORM_FILE_ERROR_INVALID_URL, error_code);
}
}
« no previous file with comments | « webkit/fileapi/file_system_url_request_job.cc ('k') | webkit/fileapi/local_file_system_test_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698