Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 10920067: Merge 154664 - Rewrite notifications documentation. (Closed)

Created:
8 years, 3 months ago by Aaron Boodman
Modified:
8 years, 3 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Merge 154664 - Rewrite notifications documentation. Add warning about a known issue that prevents icons from showing up sometimes, and generally restructure things to hopefully make more sense. Fix API sample to workaround this same issue. Also remove top and left borders from codebox because it looked weird. BUG=128344, 134315 TBR=mkwst@chromium.org Review URL: https://chromiumcodereview.appspot.com/10916075 TBR=aa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -53 lines) Patch
M chrome/common/extensions/docs/examples/api/notifications/manifest.json View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/static/css/site.css View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/notifications.html View 3 chunks +41 lines, -50 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Aaron Boodman
8 years, 3 months ago (2012-09-03 07:05:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698