android_webview/common/aw_utils.cc - Issue 10920033: Implement Android WebView BlockNetworkImages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/common/aw_utils.cc

Issue 10920033: Implement Android WebView BlockNetworkImages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update ContentSetting to new locking semantics. Add a test that does not require http server. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « android_webview/common/aw_utils.h ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java » ('j') | android_webview/renderer/aw_render_view_ext.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "android_webview/common/aw_utils.h"

	6

	7 #include "content/public/common/url_constants.h"

	8 #include "googleurl/src/gurl.h"

	9

	10 namespace android_webview {

	11

	12 bool isLocalScheme(const GURL& url) {
	mnaganov (inactive) 2012/09/25 09:55:53 I think this may not work in case of GMail, becaus I think this may not work in case of GMail, because it uses a custom scheme as a base URL, so all images will relative URLs will be using that scheme and presumably will be blocked. Perhaps, switch to using a whitelist approach for networking schemes instead? boliu 2012/09/25 16:55:12 I thought I could reuse this for BlockNetworkLoads Show quoted text On 2012/09/25 09:55:53, Mikhail Naganov (Chromium) wrote: > I think this may not work in case of GMail, because it uses a custom scheme as a > base URL, so all images will relative URLs will be using that scheme and > presumably will be blocked. Perhaps, switch to using a whitelist approach for > networking schemes instead? I thought I could reuse this for BlockNetworkLoads but since we are choosing to blacklist, then that might no longer be the case. For now removed this file and the changes in url_constants. If similar logic can be reused in BlockNetworkLoads, then do the refactor then.
	13 return url.SchemeIs(chrome::kFileScheme) \|\|

	14 url.SchemeIs(chrome::kDataScheme) \|\|

	15 url.SchemeIs(chrome::kContentScheme);

	16 }

	17

	18 } // namespace android_webview

OLD	NEW