Chromium Code Reviews
DescriptionReland: Fix and expand upon BubbleDelegateTests.
This is a continuation of https://codereview.chromium.org/10889014
That CL was reverted due to test failures in linux_chromeos and win_aura bots:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/10785/steps/views_unittests/logs/stdio
http://build.chromium.org/p/chromium/builders/Win%20Aura/builds/20590/steps/views_unittests/logs/stdio
This revised CL adds a workaround hack for Aura to activate an unrelated Widget before closing the anchor/owner widgets, so that aura::test::TestActivationClient::OnWindowDestroyed doesn't try to activate destroyed windows.
Original CL description:
===============================================
Fix and expand upon BubbleDelegateTests.
BubbleDelegateTest.ResetAnchorWidget was previously failing and crashing because of it's widget ownership pattern and lack of close_on_deactivate.
Add TestWidgetObserver to observe bubbles closing.
Ensure the bubble widget closes as expected in each test.
BUG=none
TEST=unit tests pass
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154558
Patch Set 1 #Patch Set 2 : Use an activation hack to workaround TestActivationClient. #Patch Set 3 : Check that the Bubble doesn't close on aura activation hack. #Messages
Total messages: 4 (0 generated)
|