Move hash.h/cc from net/disk_cache to base.

Move hash.h/cc from net to base.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154554

[jbates, 2012-08-31 00:07:43]

ptal

[willchan no longer on Chromium, 2012-08-31 23:02:01]

Ricardo, any concerns here? Seems reasonable to me. If you're cool with it, I'll
rubberstamp for base/.

[rvargas (doing something else), 2012-08-31 23:06:08]

lgtm

I'm cool with it. There's the bug report about moving hash to third party, but
this CL makes that easier :)

http://codereview.chromium.org/10920026/diff/2001/base/hash.h
File base/hash.h (right):

http://codereview.chromium.org/10920026/diff/2001/base/hash.h#newcode5
base/hash.h:5: #ifndef BASE_HASH_H__
nit: only one trailing undercore

http://codereview.chromium.org/10920026/diff/2001/base/hash.h#newcode17
base/hash.h:17: BASE_EXPORT_PRIVATE uint32 SuperFastHash(const char * data, int
len);
nit: Should not be private

[willchan no longer on Chromium, 2012-08-31 23:07:06]

lgtm

[jbates, 2012-08-31 23:10:41]

Thanks, also fixed up the comments in the latest CL.

http://codereview.chromium.org/10920026/diff/2001/base/hash.h
File base/hash.h (right):

http://codereview.chromium.org/10920026/diff/2001/base/hash.h#newcode5
base/hash.h:5: #ifndef BASE_HASH_H__
On 2012/08/31 23:06:08, rvargas wrote:
> nit: only one trailing undercore

Done.

http://codereview.chromium.org/10920026/diff/2001/base/hash.h#newcode17
base/hash.h:17: BASE_EXPORT_PRIVATE uint32 SuperFastHash(const char * data, int
len);
On 2012/08/31 23:06:08, rvargas wrote:
> nit: Should not be private

Done.

[jbates, 2012-08-31 23:12:55]

apatrick: content/common/gpu/OWNERS
thestig: tools/checklicenses/OWNERS

[Lei Zhang, 2012-08-31 23:14:04]

tools./checklicenses lgtm

[apatrick_chromium, 2012-08-31 23:23:32]

content/common/gpu LGTM.

But the string hasher in base/hash_tables.h is no good? It would have been less
work :)

[jbates, 2012-08-31 23:35:08]

On 2012/08/31 23:23:32, apatrick_chromium wrote:
> content/common/gpu LGTM.
> 
> But the string hasher in base/hash_tables.h is no good? It would have been
less
> work :)

I had trouble using the hash in hash_tables.h in a way that built on all
chromium platforms. No particular problem with it, otherwise, although it's a
little scary not knowing if it's the same hash algo for all platforms.