content/browser/web_contents/navigation_controller_impl_unittest.cc - Issue 10920024: Fix the fixme introduced in crrev.com/154287

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/navigation_controller_impl_unittest.cc

Issue 10920024: Fix the fixme introduced in crrev.com/154287 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/navigation_controller_impl_unittest.cc

===================================================================

--- content/browser/web_contents/navigation_controller_impl_unittest.cc (revision 154300)

+++ content/browser/web_contents/navigation_controller_impl_unittest.cc (working copy)

@@ -1452,8 +1452,7 @@

EXPECT_TRUE(notifications.Check1AndReset(

content::NOTIFICATION_NAV_ENTRY_COMMITTED));

EXPECT_TRUE(details.is_in_page);

- // TODO(tsepez): check why |did_replace_entry| is returned as false.

- EXPECT_FALSE(details.did_replace_entry);

+ EXPECT_TRUE(details.did_replace_entry);

EXPECT_EQ(1, controller.GetEntryCount());

// Fragment navigation to a new page_id.

« no previous file with comments | « content/browser/web_contents/navigation_controller_impl.cc ('k') | no next file » | no next file with comments »