Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 10920020: Remove erroneous DCHECK. The About job _is_ used in cases such as <img src="about:blank">. (Closed)

Created:
8 years, 3 months ago by erikwright (departed)
Modified:
8 years, 3 months ago
Reviewers:
mmenke
CC:
jln (very slow on Chromium), chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove erroneous DCHECK. The About job _is_ used in cases such as <img src="about:blank">. BUG=None TEST=Visit nytimes.com in a debug build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/net/about_protocol_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
erikwright (departed)
PTAL.
8 years, 3 months ago (2012-08-30 21:05:40 UTC) #1
mmenke
On 2012/08/30 21:05:40, erikwright wrote: > PTAL. LGTM, thanks!
8 years, 3 months ago (2012-08-30 21:07:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10920020/1
8 years, 3 months ago (2012-08-30 21:22:52 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-08-31 00:12:24 UTC) #4
Change committed as 154323

Powered by Google App Engine
This is Rietveld 408576698