Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/browser/sync/test/integration/two_client_apps_sync_test.cc

Issue 10920017: [Sync] Generalize StringOrdinal to handle ordinal_in_parent field (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Relax tests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc b/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
index d12cdd8b8fb416ec85e1cf96afc9a31cd750a2d8..d20443b067c817a876bfde4bbe70fdd0600fa337 100644
--- a/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_apps_sync_test.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/sync/test/integration/sync_app_helper.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/common/extensions/extension_constants.h"
+#include "sync/api/string_ordinal.h"
using apps_helper::AllProfilesHaveSameAppsAsVerifier;
using apps_helper::CopyNTPOrdinals;
@@ -337,14 +338,15 @@ IN_PROC_BROWSER_TEST_F(TwoClientAppsSyncTest, UpdatePageOrdinal) {
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
- StringOrdinal initial_page = StringOrdinal::CreateInitialOrdinal();
+ syncer::StringOrdinal initial_page =
+ syncer::StringOrdinal::CreateInitialOrdinal();
InstallApp(GetProfile(0), 0);
InstallApp(GetProfile(1), 0);
InstallApp(verifier(), 0);
ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
- StringOrdinal second_page = initial_page.CreateAfter();
+ syncer::StringOrdinal second_page = initial_page.CreateAfter();
SetPageOrdinalForApp(GetProfile(0), 0, second_page);
SetPageOrdinalForApp(verifier(), 0, second_page);
ASSERT_TRUE(AwaitQuiescence());
@@ -358,14 +360,15 @@ IN_PROC_BROWSER_TEST_F(TwoClientAppsSyncTest, UpdateAppLaunchOrdinal) {
ASSERT_TRUE(SetupSync());
ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
- StringOrdinal initial_position = StringOrdinal::CreateInitialOrdinal();
+ syncer::StringOrdinal initial_position =
+ syncer::StringOrdinal::CreateInitialOrdinal();
InstallApp(GetProfile(0), 0);
InstallApp(GetProfile(1), 0);
InstallApp(verifier(), 0);
ASSERT_TRUE(AwaitQuiescence());
ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
- StringOrdinal second_position = initial_position.CreateAfter();
+ syncer::StringOrdinal second_position = initial_position.CreateAfter();
SetAppLaunchOrdinalForApp(GetProfile(0), 0, second_position);
SetAppLaunchOrdinalForApp(verifier(), 0, second_position);
ASSERT_TRUE(AwaitQuiescence());
@@ -380,7 +383,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientAppsSyncTest, UpdateCWSOrdinals) {
ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
// Change the app launch ordinal.
- StringOrdinal cws_app_launch_ordinal = GetProfile(0)->GetExtensionService()->
+ syncer::StringOrdinal cws_app_launch_ordinal =
+ GetProfile(0)->GetExtensionService()->
extension_prefs()->extension_sorting()->GetAppLaunchOrdinal(
extension_misc::kWebStoreAppId);
GetProfile(0)->GetExtensionService()->extension_prefs()->extension_sorting()->
@@ -393,7 +397,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientAppsSyncTest, UpdateCWSOrdinals) {
ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
// Change the page ordinal.
- StringOrdinal cws_page_ordinal = GetProfile(1)->GetExtensionService()->
+ syncer::StringOrdinal cws_page_ordinal =
+ GetProfile(1)->GetExtensionService()->
extension_prefs()->extension_sorting()->GetPageOrdinal(
extension_misc::kWebStoreAppId);
GetProfile(1)->GetExtensionService()->extension_prefs()->
« no previous file with comments | « chrome/browser/sync/test/integration/sync_extension_helper.cc ('k') | chrome/browser/ui/panels/base_panel_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698