Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: chrome/browser/extensions/app_sync_data.cc

Issue 10920017: [Sync] Generalize StringOrdinal to handle ordinal_in_parent field (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Relax tests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/app_sync_data.h ('k') | chrome/browser/extensions/app_sync_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/app_sync_data.cc
diff --git a/chrome/browser/extensions/app_sync_data.cc b/chrome/browser/extensions/app_sync_data.cc
index d4d24b5bcfdceea189127455b018c4c6f8b081df..f7ce4065ee98367579d81173355a56306a5a6476 100644
--- a/chrome/browser/extensions/app_sync_data.cc
+++ b/chrome/browser/extensions/app_sync_data.cc
@@ -30,8 +30,8 @@ AppSyncData::AppSyncData(const Extension& extension,
bool incognito_enabled,
const std::string& notifications_client_id,
bool notifications_disabled,
- const StringOrdinal& app_launch_ordinal,
- const StringOrdinal& page_ordinal)
+ const syncer::StringOrdinal& app_launch_ordinal,
+ const syncer::StringOrdinal& page_ordinal)
: extension_sync_data_(extension, enabled, incognito_enabled),
notifications_client_id_(notifications_client_id),
notifications_disabled_(notifications_disabled),
@@ -65,9 +65,9 @@ void AppSyncData::PopulateAppSpecifics(sync_pb::AppSpecifics* specifics) const {
// Only sync the ordinal values if they are valid.
if (app_launch_ordinal_.IsValid())
- specifics->set_app_launch_ordinal(app_launch_ordinal_.ToString());
+ specifics->set_app_launch_ordinal(app_launch_ordinal_.ToInternalValue());
if (page_ordinal_.IsValid())
- specifics->set_page_ordinal(page_ordinal_.ToString());
+ specifics->set_page_ordinal(page_ordinal_.ToInternalValue());
extension_sync_data_.PopulateExtensionSpecifics(
specifics->mutable_extension());
@@ -88,8 +88,8 @@ void AppSyncData::PopulateFromAppSpecifics(
specifics.notification_settings().has_disabled() &&
specifics.notification_settings().disabled();
- app_launch_ordinal_ = StringOrdinal(specifics.app_launch_ordinal());
- page_ordinal_ = StringOrdinal(specifics.page_ordinal());
+ app_launch_ordinal_ = syncer::StringOrdinal(specifics.app_launch_ordinal());
+ page_ordinal_ = syncer::StringOrdinal(specifics.page_ordinal());
}
void AppSyncData::PopulateFromSyncData(const syncer::SyncData& sync_data) {
« no previous file with comments | « chrome/browser/extensions/app_sync_data.h ('k') | chrome/browser/extensions/app_sync_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698