Use new syntax for getters in test.dart and its libraries.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 107 matching lines @@
         final newCommand = new Command(newExecutablePath, newArguments);
         newCommands.add(newCommand);
         // If there are extra spaces inside the prefix or suffix, this fails.
         Expect.stringEquals('$prefix ${c.commandLine} $suffix'.trim(),
             newCommand.commandLine);
       }
       commands = newCommands;
     }
   }
 
-  int get timeout() {
+  int get timeout {
     if (expectedOutcomes.contains(SLOW)) {
       return configuration['timeout'] * SLOW_TIMEOUT_MULTIPLIER;
     } else {
       return configuration['timeout'];
     }
   }
 
-  String get configurationString() {
+  String get configurationString {
     final compiler = configuration['compiler'];
     final runtime = configuration['runtime'];
     final mode = configuration['mode'];
     final arch = configuration['arch'];
     return "$compiler-$runtime ${mode}_$arch";
   }
 
-  List<String> get batchRunnerArguments() => ['-batch'];
-  List<String> get batchTestArguments() => commands.last().arguments;
+  List<String> get batchRunnerArguments => ['-batch'];
+  List<String> get batchTestArguments => commands.last().arguments;
 
   void completed() { completedHandler(this); }
 
-  bool get usesWebDriver() => Contains(
+  bool get usesWebDriver => Contains(
       configuration['runtime'],
       const ['chrome', 'dartium', 'ff', 'safari', 'ie', 'opera']);
 }
 
 
 /**
  * BrowserTestCase has an extra compilation command that is run in a separate
  * process, before the regular test is run as in the base class [TestCase].
  * If the compilation command fails, then the rest of the test is not run.
  */
 class BrowserTestCase extends TestCase {
   /**
    * Indicates the number of potential retries remaining, to compensate for
    * flaky browser tests.
    */
   int numRetries;
 
   BrowserTestCase(displayName, commands, configuration, completedHandler,
       expectedOutcomes, [isNegative = false])
     : super(displayName, commands, configuration, completedHandler,
         expectedOutcomes, isNegative) {
     numRetries = 2; // Allow two retries to compensate for flaky browser tests.
   }
 
-  List<String> get _lastArguments() => commands.last().arguments;
+  List<String> get _lastArguments => commands.last().arguments;
 
-  List<String> get batchRunnerArguments() => [_lastArguments[0], '--batch'];
+  List<String> get batchRunnerArguments => [_lastArguments[0], '--batch'];
 
-  List<String> get batchTestArguments() =>
+  List<String> get batchTestArguments =>
       _lastArguments.getRange(1, _lastArguments.length - 1);
 }
 
 
 /**
  * TestOutput records the output of a completed test: the process's exit code,
  * the standard output and standard error, whether the process timed out, and
  * the time the process took to run.  It also contains a pointer to the
  * [TestCase] this is the output of.
  */
 interface TestOutput default TestOutputImpl {
   TestOutput.fromCase(TestCase testCase, int exitCode, bool timedOut,
     List<String> stdout, List<String> stderr, Duration time);
 
-  String get result();
+  String get result;
 
-  bool get unexpectedOutput();
+  bool get unexpectedOutput;
 
-  bool get hasCrashed();
+  bool get hasCrashed;
 
-  bool get hasTimedOut();
+  bool get hasTimedOut;
 
-  bool get didFail();
+  bool get didFail;
 
   bool requestRetry;
 
-  Duration get time();
+  Duration get time;
 
-  int get exitCode();
+  int get exitCode;
 
-  List<String> get stdout();
+  List<String> get stdout;
 
-  List<String> get stderr();
+  List<String> get stderr;
 
-  List<String> get diagnostics();
+  List<String> get diagnostics;
 }
 
 class TestOutputImpl implements TestOutput {
   TestCase testCase;
   int exitCode;
   bool timedOut;
   bool failed = false;
   List<String> stdout;
   List<String> stderr;
   Duration time;
@@ skipping 33 matching lines @@
       return new BrowserTestOutputImpl(testCase, exitCode, timedOut,
         stdout, stderr, time);
     } else if (testCase.configuration['compiler'] == 'dartc') {
       return new AnalysisTestOutputImpl(testCase, exitCode, timedOut,
         stdout, stderr, time);
     }
     return new TestOutputImpl(testCase, exitCode, timedOut,
       stdout, stderr, time);
   }
 
-  String get result() =>
+  String get result =>
       hasCrashed ? CRASH : (hasTimedOut ? TIMEOUT : (hasFailed ? FAIL : PASS));
 
-  bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
+  bool get unexpectedOutput => !testCase.expectedOutcomes.contains(result);
 
-  bool get hasCrashed() {
+  bool get hasCrashed {
     // The Java dartc runner and dart2js exits with code 253 in case
     // of unhandled exceptions.
     if (exitCode == 253) return true;
     if (Platform.operatingSystem == 'windows') {
       // The VM uses std::abort to terminate on asserts.
       // std::abort terminates with exit code 3 on Windows.
       if (exitCode == 3) {
         return !timedOut;
       }
       return (!timedOut && (exitCode < 0) && ((0x3FFFFF00 & exitCode) == 0));
     }
     return !timedOut && ((exitCode < 0));
   }
 
-  bool get hasTimedOut() => timedOut;
+  bool get hasTimedOut => timedOut;
 
-  bool get didFail() {
+  bool get didFail {
     return (exitCode != 0 && !hasCrashed);
   }
 
   // Reverse result of a negative test.
-  bool get hasFailed() => testCase.isNegative ? !didFail : didFail;
+  bool get hasFailed => testCase.isNegative ? !didFail : didFail;
 
 }
 
 class BrowserTestOutputImpl extends TestOutputImpl {
   BrowserTestOutputImpl(testCase, exitCode, timedOut, stdout, stderr, time) :
     super(testCase, exitCode, timedOut, stdout, stderr, time);
 
-  bool get didFail() {
+  bool get didFail {
     // Browser case:
     // If the browser test failed, it may have been because DumpRenderTree
     // and the virtual framebuffer X server didn't hook up, or DRT crashed with
     // a core dump. Sometimes DRT crashes after it has set the stdout to PASS,
     // so we have to do this check first.
     for (String line in super.stderr) {
       if (line.contains('Gtk-WARNING **: cannot open display: :99') ||
         line.contains('Failed to run command. return code=1')) {
         // If we get the X server error, or DRT crashes with a core dump, retry
         // the test.
@@ skipping 32 matching lines @@
   final int ERROR_LEVEL = 0;
   final int ERROR_TYPE = 1;
   final int FORMATTED_ERROR = 7;
 
   bool alreadyComputed = false;
   bool failResult;
   AnalysisTestOutputImpl(testCase, exitCode, timedOut, stdout, stderr, time) :
     super(testCase, exitCode, timedOut, stdout, stderr, time) {
   }
 
-  bool get didFail() {
+  bool get didFail {
     if (!alreadyComputed) {
       failResult = _didFail();
       alreadyComputed = true;
     }
     return failResult;
   }
 
   bool _didFail() {
     if (hasCrashed) return false;
 
@@ skipping 309 matching lines @@
   Timer _timer;
 
   bool _isWebDriver;
 
   BatchRunnerProcess(TestCase testCase) {
     _executable = testCase.commands.last().executable;
     _batchArguments = testCase.batchRunnerArguments;
     _isWebDriver = testCase.usesWebDriver;
   }
 
-  bool get active() => _currentTest != null;
+  bool get active => _currentTest != null;
 
   void startTest(TestCase testCase) {
     Expect.isNull(_currentTest);
     _currentTest = testCase;
     if (_process === null) {
       // Start process if not yet started.
       _executable = testCase.commands.last().executable;
       _startProcess(() {
         doStartTest(testCase);
       });
@@ skipping 294 matching lines @@
         _terminateBatchRunners();
         _cleanupAndMarkDone();
       }
     }
   }
 
   /**
    * True if we are using a browser + platform combination that needs the
    * Selenium server jar.
    */
-  bool get _needsSelenium() => Platform.operatingSystem == 'macos' &&
+  bool get _needsSelenium => Platform.operatingSystem == 'macos' &&
       browserUsed == 'safari';
 
   /** True if the Selenium Server is ready to be used. */
-  bool get _isSeleniumAvailable() => _seleniumServer != null ||
+  bool get _isSeleniumAvailable => _seleniumServer != null ||
       _seleniumAlreadyRunning;
 
   /**
    * Restart all the processes that have been waiting/stopped for the server to
    * start up. If we just call this once we end up with a single-"threaded" run.
    */
   void resumeTesting() {
     for (int i = 0; i < _maxProcesses; i++) _tryRunTest();
   }
 
@@ skipping 171 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }