Installer changes for app host to support command line install from webstore

chrome/installer/setup/install_worker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the definitions of the installer functions that build
 // the WorkItemList used to install the application.
 
 #include "chrome/installer/setup/install_worker.h"
 
 #include <oaidl.h>
@@ skipping 170 matching lines @@
   cmd_key.append(1, L'\\').append(google_update::kRegCommandsKey)
       .append(1, L'\\').append(kCmdInstallApp);
 
   if (installer_state.operation() == InstallerState::UNINSTALL) {
     work_item_list->AddDeleteRegKeyWorkItem(
         installer_state.root_key(), cmd_key)->set_log_message(
             "removing install-application command");
   } else {
     CommandLine cmd_line(
         installer_state.target_path().Append(installer::kChromeAppHostExe));
-    cmd_line.AppendSwitchASCII(::switches::kAppsInstallFromManifestURL, "%1");
+    cmd_line.AppendSwitchASCII(::switches::kInstallFromWebstore, "%1");

[gab, 2012/09/18 16:44:21]

According to the comments on those switches: kAppsInstallFromManifestURL took a
URL while kInstallFromWebstore takes an app ID... are app IDs URL? was this
previously broken? (i.e. when is this invoked and what is "%1"?).

[asargent_no_longer_on_chrome, 2012/09/18 16:59:14]

This code was written in advance of chrome actually supporting the
kAppsInstallFromManifestURL flag, so passing it was just a no-op.

I was tasked with actually implementing that functionality in chrome, but it
turned out to be easier to pass an app id than a URL to an app, because we
already had inline install code
(https://developers.google.com/chrome/web-store/docs/inline_installation) which
just needs the id. So the code we'll be using to call the installer will just
pass this id instead of a URL. 

 
     AppCommand cmd(cmd_line.GetCommandLineString());
     cmd.set_sends_pings(true);
     cmd.set_is_web_accessible(true);
     cmd.AddWorkItems(installer_state.root_key(), cmd_key, work_item_list);
   }
 }
 
 void AddProductSpecificWorkItems(const InstallationState& original_state,
                                  const InstallerState& installer_state,
@@ skipping 1391 matching lines @@
     // Log everything for now.
     cmd_line.AppendSwitch(installer::switches::kVerboseLogging);
 
     AppCommand cmd(cmd_line.GetCommandLineString());
     cmd.set_is_auto_run_on_os_upgrade(true);
     cmd.AddWorkItems(installer_state.root_key(), cmd_key, install_list);
   }
 }
 
 }  // namespace installer