Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10919317: Move TestJobInterceptor to url_request_test_util. (Closed)

Created:
8 years, 3 months ago by droger
Modified:
8 years, 3 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, stuartmorgan, cgrigoruta_google.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move TestJobInterceptor to url_request_test_util. TestJobInterceptor is now accessible to other tests. BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157345

Patch Set 1 : Fix typo #

Total comments: 1

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -35 lines) Patch
M net/url_request/url_request_test_util.h View 1 2 chunks +24 lines, -0 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
droger
8 years, 3 months ago (2012-09-17 15:21:48 UTC) #1
wtc
Patch set 1 LGTM. https://codereview.chromium.org/10919317/diff/2001/net/url_request/url_request_test_util.h File net/url_request/url_request_test_util.h (right): https://codereview.chromium.org/10919317/diff/2001/net/url_request/url_request_test_util.h#newcode302 net/url_request/url_request_test_util.h:302: // A simple Interceptor that ...
8 years, 3 months ago (2012-09-17 22:52:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/10919317/10001
8 years, 3 months ago (2012-09-18 07:55:24 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-18 10:26:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/10919317/10001
8 years, 3 months ago (2012-09-18 11:12:03 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 14:02:04 UTC) #6 
Change committed as 157345

Powered by Google App Engine
This is Rietveld 408576698