Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chrome/browser/extensions/data_deleter.cc

Issue 10919307: Move IndexedDBContext into the StoragePartition and ensure isolation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove useless include Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/data_deleter.h" 5 #include "chrome/browser/extensions/data_deleter.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "chrome/browser/extensions/extension_service.h" 9 #include "chrome/browser/extensions/extension_service.h"
10 #include "chrome/browser/extensions/settings/settings_frontend.h" 10 #include "chrome/browser/extensions/settings/settings_frontend.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 BrowserThread::IO, FROM_HERE, 47 BrowserThread::IO, FROM_HERE,
48 base::Bind(&DataDeleter::DeleteCookiesOnIOThread, deleter)); 48 base::Bind(&DataDeleter::DeleteCookiesOnIOThread, deleter));
49 49
50 content::BrowserContext::GetDefaultStoragePartition(profile)-> 50 content::BrowserContext::GetDefaultStoragePartition(profile)->
51 GetDOMStorageContext()->DeleteOrigin(storage_origin); 51 GetDOMStorageContext()->DeleteOrigin(storage_origin);
52 52
53 BrowserThread::PostTask( 53 BrowserThread::PostTask(
54 BrowserThread::WEBKIT_DEPRECATED, FROM_HERE, 54 BrowserThread::WEBKIT_DEPRECATED, FROM_HERE,
55 base::Bind( 55 base::Bind(
56 &DataDeleter::DeleteIndexedDBOnWebkitThread, 56 &DataDeleter::DeleteIndexedDBOnWebkitThread,
57 deleter, 57 deleter));
58 make_scoped_refptr(BrowserContext::GetIndexedDBContext(profile))));
59 58
60 BrowserThread::PostTask( 59 BrowserThread::PostTask(
61 BrowserThread::FILE, FROM_HERE, 60 BrowserThread::FILE, FROM_HERE,
62 base::Bind(&DataDeleter::DeleteDatabaseOnFileThread, deleter)); 61 base::Bind(&DataDeleter::DeleteDatabaseOnFileThread, deleter));
63 62
64 BrowserThread::PostTask( 63 BrowserThread::PostTask(
65 BrowserThread::FILE, FROM_HERE, 64 BrowserThread::FILE, FROM_HERE,
66 base::Bind(&DataDeleter::DeleteFileSystemOnFileThread, deleter)); 65 base::Bind(&DataDeleter::DeleteFileSystemOnFileThread, deleter));
67 66
68 BrowserThread::PostTask( 67 BrowserThread::PostTask(
(...skipping 12 matching lines...) Expand all
81 const std::string& extension_id, 80 const std::string& extension_id,
82 const GURL& storage_origin, 81 const GURL& storage_origin,
83 bool is_storage_isolated) 82 bool is_storage_isolated)
84 : extension_id_(extension_id) { 83 : extension_id_(extension_id) {
85 // TODO(michaeln): Delete from the right StoragePartition. 84 // TODO(michaeln): Delete from the right StoragePartition.
86 // http://crbug.com/85127 85 // http://crbug.com/85127
87 database_tracker_ = BrowserContext::GetDefaultStoragePartition(profile)-> 86 database_tracker_ = BrowserContext::GetDefaultStoragePartition(profile)->
88 GetDatabaseTracker(); 87 GetDatabaseTracker();
89 // Pick the right request context depending on whether it's an extension, 88 // Pick the right request context depending on whether it's an extension,
90 // isolated app, or regular app. 89 // isolated app, or regular app.
90 content::StoragePartition* storage_partition =
91 BrowserContext::GetDefaultStoragePartition(profile);
91 if (storage_origin.SchemeIs(chrome::kExtensionScheme)) { 92 if (storage_origin.SchemeIs(chrome::kExtensionScheme)) {
92 extension_request_context_ = profile->GetRequestContextForExtensions(); 93 extension_request_context_ = profile->GetRequestContextForExtensions();
93 } else if (is_storage_isolated) { 94 } else if (is_storage_isolated) {
94 extension_request_context_ = 95 extension_request_context_ =
95 profile->GetRequestContextForIsolatedApp(extension_id); 96 profile->GetRequestContextForIsolatedApp(extension_id);
96 isolated_app_path_ = 97 isolated_app_path_ =
97 profile->GetPath().Append( 98 profile->GetPath().Append(
98 content::StoragePartition::GetPartitionPath(extension_id)); 99 content::StoragePartition::GetPartitionPath(extension_id));
99 } else { 100 } else {
100 extension_request_context_ = profile->GetRequestContext(); 101 extension_request_context_ = profile->GetRequestContext();
101 } 102 }
103
102 file_system_context_ = BrowserContext::GetFileSystemContext(profile); 104 file_system_context_ = BrowserContext::GetFileSystemContext(profile);
105 indexed_db_context_ = storage_partition->GetIndexedDBContext();
106
103 storage_origin_ = storage_origin; 107 storage_origin_ = storage_origin;
104 origin_id_ = 108 origin_id_ =
105 webkit_database::DatabaseUtil::GetOriginIdentifier(storage_origin_); 109 webkit_database::DatabaseUtil::GetOriginIdentifier(storage_origin_);
106 } 110 }
107 111
108 DataDeleter::~DataDeleter() { 112 DataDeleter::~DataDeleter() {
109 } 113 }
110 114
111 void DataDeleter::DeleteCookiesOnIOThread() { 115 void DataDeleter::DeleteCookiesOnIOThread() {
112 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 116 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
113 net::CookieMonster* cookie_monster = 117 net::CookieMonster* cookie_monster =
114 extension_request_context_->GetURLRequestContext()->cookie_store()-> 118 extension_request_context_->GetURLRequestContext()->cookie_store()->
115 GetCookieMonster(); 119 GetCookieMonster();
116 if (cookie_monster) 120 if (cookie_monster)
117 cookie_monster->DeleteAllForHostAsync( 121 cookie_monster->DeleteAllForHostAsync(
118 storage_origin_, net::CookieMonster::DeleteCallback()); 122 storage_origin_, net::CookieMonster::DeleteCallback());
119 } 123 }
120 124
121 void DataDeleter::DeleteDatabaseOnFileThread() { 125 void DataDeleter::DeleteDatabaseOnFileThread() {
122 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); 126 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
123 int rv = database_tracker_->DeleteDataForOrigin( 127 int rv = database_tracker_->DeleteDataForOrigin(
124 origin_id_, net::CompletionCallback()); 128 origin_id_, net::CompletionCallback());
125 DCHECK(rv == net::OK || rv == net::ERR_IO_PENDING); 129 DCHECK(rv == net::OK || rv == net::ERR_IO_PENDING);
126 } 130 }
127 131
128 void DataDeleter::DeleteIndexedDBOnWebkitThread( 132 void DataDeleter::DeleteIndexedDBOnWebkitThread() {
129 scoped_refptr<IndexedDBContext> indexed_db_context) {
130 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT_DEPRECATED)); 133 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::WEBKIT_DEPRECATED));
131 indexed_db_context->DeleteForOrigin(storage_origin_); 134 indexed_db_context_->DeleteForOrigin(storage_origin_);
132 } 135 }
133 136
134 void DataDeleter::DeleteFileSystemOnFileThread() { 137 void DataDeleter::DeleteFileSystemOnFileThread() {
135 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE)); 138 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
136 file_system_context_->DeleteDataForOriginOnFileThread(storage_origin_); 139 file_system_context_->DeleteDataForOriginOnFileThread(storage_origin_);
137 140
138 // TODO(creis): The following call fails because the request context is still 141 // TODO(creis): The following call fails because the request context is still
139 // around, and holding open file handles in this directory. 142 // around, and holding open file handles in this directory.
140 // See http://crbug.com/85127 143 // See http://crbug.com/85127
141 if (!isolated_app_path_.empty()) 144 if (!isolated_app_path_.empty())
142 file_util::Delete(isolated_app_path_, true); 145 file_util::Delete(isolated_app_path_, true);
143 } 146 }
144 147
145 void DataDeleter::DeleteAppcachesOnIOThread( 148 void DataDeleter::DeleteAppcachesOnIOThread(
146 appcache::AppCacheService* appcache_service) { 149 appcache::AppCacheService* appcache_service) {
147 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 150 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
148 appcache_service->DeleteAppCachesForOrigin(storage_origin_, 151 appcache_service->DeleteAppCachesForOrigin(storage_origin_,
149 net::CompletionCallback()); 152 net::CompletionCallback());
150 } 153 }
151 154
152 } // namespace extensions 155 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/data_deleter.h ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698