Photo Editor: better mode transitions

Photo Editor: better mode transitions

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156844

[dgozman, 2012-09-14 15:17:38]

LGTM

http://codereview.chromium.org/10919292/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/js/image_editor/image_view.js
(right):

http://codereview.chromium.org/10919292/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/image_editor/image_view.js:667: *
@param {number} opt_duration Transition duration.
number=

http://codereview.chromium.org/10919292/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/image_editor/image_view.js:671: if
(opt_duration == undefined)
I'd use typeof(opt_duration) == "number"

http://codereview.chromium.org/10919292/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/js/photo/mosaic_mode.js (right):

http://codereview.chromium.org/10919292/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/photo/mosaic_mode.js:438: if
(opt_instant)
braces must be present when else clause is present

http://codereview.chromium.org/10919292/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/js/photo/slide_mode.js (right):

http://codereview.chromium.org/10919292/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/photo/slide_mode.js:359: if
(this.getSelectedIndex() < 0)
No selection in slide mode?

[Vladislav Kaznacheev, 2012-09-14 16:20:04]

Thanks for the review. Will commit now to make the branch. I will fix the 3
style issues in the next patch, I promise:)

https://chromiumcodereview.appspot.com/10919292/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/photo/slide_mode.js (right):

https://chromiumcodereview.appspot.com/10919292/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/photo/slide_mode.js:359: if
(this.getSelectedIndex() < 0)
It is possible if there is 0 items. 
On 2012/09/14 15:17:38, dgozman wrote:
> No selection in slide mode?

[commit-bot: I haz the power, 2012-09-14 16:20:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10919292/1

[commit-bot: I haz the power, 2012-09-14 17:46:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10919292/1

[commit-bot: I haz the power, 2012-09-14 18:27:58]

Change committed as 156844