Handle certificate generation errors in chromoting host.

Handle certificate generation errors in chromoting host.

Sometimes self-signed cert generation may fail. In that case it's better to shutdown
host instead of crashing.

BUG=146839
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156736

[alexeypa (please no reviews), 2012-09-13 23:09:25]

lgtm

http://codereview.chromium.org/10919277/diff/1004/remoting/host/host_key_pair.cc
File remoting/host/host_key_pair.cc (right):

http://codereview.chromium.org/10919277/diff/1004/remoting/host/host_key_pair...
remoting/host/host_key_pair.cc:109: return "";
nit: return std::string();?

Or you can wrap net::X509Certificate::GetDEREncoded() call into if (cert) {}

http://codereview.chromium.org/10919277/diff/1004/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10919277/diff/1004/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:268: local_certificate,
*key_pair_.private_key(), host_secret_hash_));
nit: There is similar code in remoting_simple_host. Do we still care about it?
Should we get rid of the simple host entirely?

[Sergey Ulanov, 2012-09-13 23:25:17]

http://codereview.chromium.org/10919277/diff/1004/remoting/host/host_key_pair.cc
File remoting/host/host_key_pair.cc (right):

http://codereview.chromium.org/10919277/diff/1004/remoting/host/host_key_pair...
remoting/host/host_key_pair.cc:109: return "";
On 2012/09/13 23:09:25, alexeypa wrote:
> nit: return std::string();?
> 
> Or you can wrap net::X509Certificate::GetDEREncoded() call into if (cert) {}

Done.

http://codereview.chromium.org/10919277/diff/1004/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10919277/diff/1004/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:268: local_certificate,
*key_pair_.private_key(), host_secret_hash_));
On 2012/09/13 23:09:25, alexeypa wrote:
> nit: There is similar code in remoting_simple_host. Do we still care about it?

Nah - it's there for debugging, it's ok if it crashes.

> Should we get rid of the simple host entirely?

I think yes, especially if causes a lot of burden to support. It's was useful
for debugging, but I think remoting_me2me_host can be used now for the same
purposes.

[commit-bot: I haz the power, 2012-09-13 23:55:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10919277/6003

[commit-bot: I haz the power, 2012-09-14 04:18:05]

Change committed as 156736