Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: content/public/browser/download_item.h

Issue 10919271: Make more precise the consumer intended use of GetTargetFullPath() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/download_item.h
diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h
index 5acd89d370bb2ff9e005854b35d0a7baa8528338..2b10f502ca82c3e810a1f54ac12d633ddf741094 100644
--- a/content/public/browser/download_item.h
+++ b/content/public/browser/download_item.h
@@ -204,13 +204,15 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData {
// Destination State accessors --------------------------------------------
// Full path to the downloaded or downloading file. This is the path to the
- // physical file, if one exists. Can be empty if the in-progress path hasn't
- // been determined yet.
+ // physical file, if one exists. It should be considered a hint; changes to
+ // this value and renames of the file on disk are not atomic with each other.
+ // May be empty if the in-progress path hasn't been determined yet.
virtual const FilePath& GetFullPath() const = 0;
// Target path of an in-progress download. We may be downloading to a
- // temporary or intermediate file (specified by |current_path_|. Once the
- // download completes, we will rename the file to |target_path_|.
+ // temporary or intermediate file (specified by GetFullPath()); this is the
+ // name we will use once the download completes.
+ // May be empty if the target path hasn't yet been determined.
virtual const FilePath& GetTargetFilePath() const = 0;
// |GetTargetFilePath().BaseName()|
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698