Improved cloud print service installation.

Improved cloud print service installation.

Removed quiet option.
Prompt for Windows user/password instead of switches.
Show printers available for selected account.
Check permissions and available printers in real system process.
Generate guid as proxy_id if it's empty.

BUG=148913
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156719

[Vitaly Buka (NO REVIEWS), 2012-09-13 08:45:42]

Please review.

[gene, 2012-09-13 18:40:09]

nit: In description
"Removed quite option." -> "Remove quiet option."

https://codereview.chromium.org/10919262/diff/6001/cloud_print/service/win/cl...
File cloud_print/service/win/cloud_print_service.cc (right):

https://codereview.chromium.org/10919262/diff/6001/cloud_print/service/win/cl...
cloud_print/service/win/cloud_print_service.cc:269: return S_FALSE;
nit: Could you please a small comment why we return S_FALSE here?

https://codereview.chromium.org/10919262/diff/6001/cloud_print/service/win/cl...
cloud_print/service/win/cloud_print_service.cc:345: if (!run_as_user ||
!run_as_password)
nit: remove this if?
I would rather crash (assert will be even better) if params are null.

https://codereview.chromium.org/10919262/diff/6001/cloud_print/service/win/cl...
cloud_print/service/win/cloud_print_service.cc:361: continue;
Any consistent failures in InstallService, StartService or failure to create
file will cause infinite loop here. Can we try 3 times (for example) and then
exit with error?

[Vitaly Buka (NO REVIEWS), 2012-09-13 20:01:51]

https://codereview.chromium.org/10919262/diff/6001/cloud_print/service/win/cl...
File cloud_print/service/win/cloud_print_service.cc (right):

https://codereview.chromium.org/10919262/diff/6001/cloud_print/service/win/cl...
cloud_print/service/win/cloud_print_service.cc:269: return S_FALSE;
On 2012/09/13 18:40:09, gene wrote:
> nit: Could you please a small comment why we return S_FALSE here?

Done.

https://codereview.chromium.org/10919262/diff/6001/cloud_print/service/win/cl...
cloud_print/service/win/cloud_print_service.cc:345: if (!run_as_user ||
!run_as_password)
On 2012/09/13 18:40:09, gene wrote:
> nit: remove this if?
> I would rather crash (assert will be even better) if params are null.

Done.

https://codereview.chromium.org/10919262/diff/6001/cloud_print/service/win/cl...
cloud_print/service/win/cloud_print_service.cc:361: continue;
It's console app so it could be stopped with Ctrl+Break any time

On 2012/09/13 18:40:09, gene wrote:
> Any consistent failures in InstallService, StartService or failure to create
> file will cause infinite loop here. Can we try 3 times (for example) and then
> exit with error?

[gene, 2012-09-13 23:53:02]

lgtm

[commit-bot: I haz the power, 2012-09-13 23:54:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10919262/8

[commit-bot: I haz the power, 2012-09-14 02:36:23]

Change committed as 156719