Fix img misalign and hide "by" when nothing selected in new wallpaepr picker ui

Fix img misalign in new wallpaper picker ui


BUG=148424, 148751
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156633

[bshe, 2012-09-12 21:26:48]

Hi Rob.

Could you please take a look at this tiny CL?

Screenshots of the problem is here:
http://cros-hwqual-5.mtv.corp.google.com/bugs/screenshots/Screenshot2012-09-1...

Thanks!

[bshe, 2012-09-12 21:48:47]

Patch set 2 for issue 148751. The changes are small enough so I combine them
into one CL.

Thanks!

On 2012/09/12 21:26:48, bshe wrote:
> Hi Rob.
> 
> Could you please take a look at this tiny CL?
> 
> Screenshots of the problem is here:
>
http://cros-hwqual-5.mtv.corp.google.com/bugs/screenshots/Screenshot2012-09-1...
> 
> Thanks!

[flackr, 2012-09-13 02:34:27]

http://codereview.chromium.org/10919253/diff/3001/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

http://codereview.chromium.org/10919253/diff/3001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:127:
* screen shot.
This could potentially show images at the wrong aspect ratio, I assume this is
acceptable for the wallpapers we plan to show for now?

http://codereview.chromium.org/10919253/diff/3001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:139:
#wallpaper-attr {
I don't think there's any need to abbreviate this, can we change it to
wallpaper-attribution, which I assume it's short for.

http://codereview.chromium.org/10919253/diff/3001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:144:
#wallpaper-attr[hidden] {
perhaps just *[hidden]?

[bshe, 2012-09-13 03:45:47]

Thanks for review

http://codereview.chromium.org/10919253/diff/3001/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

http://codereview.chromium.org/10919253/diff/3001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:127:
* screen shot.
Yes. All the thumbnails are downloaded from server and their size are 128x80 for
now.

On 2012/09/13 02:34:27, flackr wrote:
> This could potentially show images at the wrong aspect ratio, I assume this is
> acceptable for the wallpapers we plan to show for now?

http://codereview.chromium.org/10919253/diff/3001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:139:
#wallpaper-attr {
On 2012/09/13 02:34:27, flackr wrote:
> I don't think there's any need to abbreviate this, can we change it to
> wallpaper-attribution, which I assume it's short for.

Done.

http://codereview.chromium.org/10919253/diff/3001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:144:
#wallpaper-attr[hidden] {
On 2012/09/13 02:34:27, flackr wrote:
> perhaps just *[hidden]?

Done.

[flackr, 2012-09-13 20:55:01]

lgtm

http://codereview.chromium.org/10919253/diff/8001/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

http://codereview.chromium.org/10919253/diff/8001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:120:
* image size may be used when layout. Some images may be misaligned as a
grammar nit: "Otherwise, an incorrect image size may be used during layout."

[bshe, 2012-09-13 21:13:53]

Done. Thanks!

http://codereview.chromium.org/10919253/diff/8001/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

http://codereview.chromium.org/10919253/diff/8001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:120:
* image size may be used when layout. Some images may be misaligned as a
On 2012/09/13 20:55:01, flackr wrote:
> grammar nit: "Otherwise, an incorrect image size may be used during layout."

Done.