Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 10919236: Support multi display candidate window. (Closed)

Created:
8 years, 3 months ago by Seigo Nonaka
Modified:
8 years, 3 months ago
Reviewers:
mazda
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Support multi display candidate window. BUG=147394 TEST=Manually done on lumpy Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156544

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments and move to ResizeAndMoveParentFrame function #

Patch Set 3 : No reparent #

Patch Set 4 : remove unused inclusion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Seigo Nonaka
8 years, 3 months ago (2012-09-12 09:02:41 UTC) #1
mazda
http://codereview.chromium.org/10919236/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc File chrome/browser/chromeos/input_method/candidate_window.cc (right): http://codereview.chromium.org/10919236/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc#newcode1680 chrome/browser/chromeos/input_method/candidate_window.cc:1680: views::Widget::ReparentNativeView(frame_->GetNativeView(), Is it necessary to do this here? I ...
8 years, 3 months ago (2012-09-12 16:49:45 UTC) #2
Seigo Nonaka
http://codereview.chromium.org/10919236/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc File chrome/browser/chromeos/input_method/candidate_window.cc (right): http://codereview.chromium.org/10919236/diff/1/chrome/browser/chromeos/input_method/candidate_window.cc#newcode1680 chrome/browser/chromeos/input_method/candidate_window.cc:1680: views::Widget::ReparentNativeView(frame_->GetNativeView(), Seems transient window like CandidateWindow does not move ...
8 years, 3 months ago (2012-09-12 17:24:50 UTC) #3
Seigo Nonaka
Sorry, I misunderstand the root of problem. The root of this cause is boundary fitting ...
8 years, 3 months ago (2012-09-13 07:07:56 UTC) #4
mazda
lgtm
8 years, 3 months ago (2012-09-13 08:18:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10919236/5003
8 years, 3 months ago (2012-09-13 08:36:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10919236/5003
8 years, 3 months ago (2012-09-13 10:21:20 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s)
8 years, 3 months ago (2012-09-13 10:58:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10919236/5003
8 years, 3 months ago (2012-09-13 11:39:06 UTC) #9
commit-bot: I haz the power
Retried try job too often for step(s) sync_integration_tests, chrome_frame_unittests, safe_browsing_tests, mini_installer_test, ui_tests, remoting_unittests, installer_util_unittests, gfx_unittests, ...
8 years, 3 months ago (2012-09-13 12:13:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10919236/5003
8 years, 3 months ago (2012-09-13 14:24:08 UTC) #11
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 14:24:24 UTC) #12
Change committed as 156544

Powered by Google App Engine
This is Rietveld 408576698