Fix array index dehoisting.

src/hydrogen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3730 matching lines @@
 }
 
 
 static void DehoistArrayIndex(ArrayInstructionInterface* array_operation) {
   HValue* index = array_operation->GetKey();
 
   HConstant* constant;
   HValue* subexpression;
   int32_t sign;
   if (index->IsAdd()) {
+    if (!index->representation().IsInteger32())
+      return;

[Jakob Kummerow, 2012/09/11 13:16:24]

{} please (or put it all on one line).
Again below.

Also, you could do with a single copy of this condition if you move it up and
out of the if-block.

     sign = 1;
     HAdd* add = HAdd::cast(index);
     if (add->left()->IsConstant()) {
       subexpression = add->right();
       constant = HConstant::cast(add->left());
     } else if (add->right()->IsConstant()) {
       subexpression = add->left();
       constant = HConstant::cast(add->right());
     } else {
       return;
     }
   } else if (index->IsSub()) {
+    if (!index->representation().IsInteger32())
+      return;
     sign = -1;
     HSub* sub = HSub::cast(index);
     if (sub->left()->IsConstant()) {
       subexpression = sub->right();
       constant = HConstant::cast(sub->left());
     } else if (sub->right()->IsConstant()) {
       subexpression = sub->left();
       constant = HConstant::cast(sub->right());
     } return;
   } else {
@@ skipping 6203 matching lines @@
     }
   }
 
 #ifdef DEBUG
   if (graph_ != NULL) graph_->Verify(false);  // No full verify.
   if (allocator_ != NULL) allocator_->Verify();
 #endif
 }
 
 } }  // namespace v8::internal