Implement RemovableDeviceNotifications for Mac

chrome/browser/system_monitor/disk_info_mac.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYSTEM_MONITOR_DISK_INFO_MAC_H_
+#define CHROME_BROWSER_SYSTEM_MONITOR_DISK_INFO_MAC_H_
+
+#include <CoreFoundation/CoreFoundation.h>
+
+#include "base/file_path.h"
+#include "chrome/browser/system_monitor/media_storage_util.h"
+
+namespace chrome {
+
+// This class stores information about a particular disk. This class is not
+// thread safe and must only be used from the file thread.

[Nico, 2012/09/10 07:02:34]

Looks like only the static function isn't threadsafe. Maybe move the comment to
there.

[sail, 2012/09/10 21:58:43]

Done.

+class DiskInfoMac {
+ public:
+  DiskInfoMac();
+  ~DiskInfoMac();
+
+  static DiskInfoMac BuildDiskInfoOnFileThread(CFDictionaryRef dict);
+
+  const std::string& bsd_name() const { return bsd_name_; }
+  const std::string& device_id() const { return device_id_; }
+  const string16 display_name() const { return display_name_; }
+  const FilePath& mount_point() const { return mount_point_; }
+  MediaStorageUtil::Type type() const { return type_; }
+
+ private:
+  std::string bsd_name_;
+  std::string device_id_;
+  string16 display_name_;
+  FilePath mount_point_;
+  MediaStorageUtil::Type type_;

[vandebo (ex-Chrome), 2012/09/10 18:45:03]

You don't really need to store type separate from device_id.  Though I guess if
you plan to use it a lot it might be more efficient.

[sail, 2012/09/10 21:58:43]

Yea, it seemed easier to store it than breaking appart device id.

+};
+
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_SYSTEM_MONITOR_DISK_INFO_MAC_H_