Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 10919173: Rename Windows SystemMonitor implementation files. (Closed)

Created:
8 years, 3 months ago by vandebo (ex-Chrome)
Modified:
8 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Rename Windows SystemMonitor implementation files. Also, add an OWNERS file. BUG=145400 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155583

Patch Set 1 #

Patch Set 2 : Owners #

Patch Set 3 : nit #

Total comments: 2

Patch Set 4 : Address comment #

Patch Set 5 : Fix win unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -480 lines) Patch
M chrome/browser/chrome_browser_main_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A chrome/browser/system_monitor/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/browser/system_monitor/media_device_notifications_window_win.h View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/system_monitor/media_device_notifications_window_win.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D chrome/browser/system_monitor/media_device_notifications_window_win_unittest.cc View 1 chunk +0 lines, -212 lines 0 comments Download
A chrome/browser/system_monitor/removable_device_notifications_window_win.h View 1 2 3 1 chunk +71 lines, -0 lines 0 comments Download
A chrome/browser/system_monitor/removable_device_notifications_window_win.cc View 1 2 3 1 chunk +191 lines, -0 lines 0 comments Download
A chrome/browser/system_monitor/removable_device_notifications_window_win_unittest.cc View 1 2 3 4 1 chunk +212 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vandebo (ex-Chrome)
8 years, 3 months ago (2012-09-08 01:15:00 UTC) #1
Lei Zhang
lgtm https://chromiumcodereview.appspot.com/10919173/diff/4001/chrome/browser/system_monitor/OWNERS File chrome/browser/system_monitor/OWNERS (right): https://chromiumcodereview.appspot.com/10919173/diff/4001/chrome/browser/system_monitor/OWNERS#newcode3 chrome/browser/system_monitor/OWNERS:3: nit: extra blank line
8 years, 3 months ago (2012-09-08 01:19:23 UTC) #2
vandebo (ex-Chrome)
https://chromiumcodereview.appspot.com/10919173/diff/4001/chrome/browser/system_monitor/OWNERS File chrome/browser/system_monitor/OWNERS (right): https://chromiumcodereview.appspot.com/10919173/diff/4001/chrome/browser/system_monitor/OWNERS#newcode3 chrome/browser/system_monitor/OWNERS:3: On 2012/09/08 01:19:23, Lei Zhang wrote: > nit: extra ...
8 years, 3 months ago (2012-09-08 01:58:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10919173/7002
8 years, 3 months ago (2012-09-08 01:58:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10919173/2012
8 years, 3 months ago (2012-09-08 03:34:54 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-08 17:37:38 UTC) #6
Change committed as 155583

Powered by Google App Engine
This is Rietveld 408576698