Issue 10919117: Back port r12439 and r12442 to the 3.9 branch:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10919117: Back port r12439 and r12442 to the 3.9 branch: (Closed)

Created:
8 years, 3 months ago by Erik Corry

Modified:
8 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/3.9/

Visibility:
Public.

More Reviews

Description

Back port r12439 and r12442 to the 3.9 branch: Fix some corner cases in skipping native methods using caller. Fix binding in new Function(). Committed: https://code.google.com/p/v8/source/detail?r=12459

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -2 lines)			Patch
M	src/accessors.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/v8natives.js	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/new-function.js	View	1 chunk	+34 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-145201.js	View	1 chunk	+107 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/09/06 08:08:36, Erik Corry wrote:

LGTM.

Expand Messages | Collapse Messages