Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 10919113: Move fullscreen_controller browser tests to interactive. (Closed)

Created:
8 years, 3 months ago by scheib
Modified:
8 years, 3 months ago
Reviewers:
Robert Sesek, sky
CC:
chromium-reviews, scheib+watch_chromium.org, yzshen1
Visibility:
Public.

Description

Move fullscreen_controller browser tests to interactive. BUG=146665 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155422

Patch Set 1 #

Patch Set 2 : Cross platform safe include of mac specific header #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -457 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_browsertest.cc View 2 chunks +0 lines, -401 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc View 1 7 chunks +474 lines, -4 lines 2 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_test.cc View 2 chunks +0 lines, -49 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scheib
8 years, 3 months ago (2012-09-06 00:13:39 UTC) #1
Robert Sesek
https://chromiumcodereview.appspot.com/10919113/diff/5003/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc File chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc (right): https://chromiumcodereview.appspot.com/10919113/diff/5003/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc#newcode170 chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc:170: } while (retry_until_success && Is this part still necessary ...
8 years, 3 months ago (2012-09-06 18:20:51 UTC) #2
scheib
https://chromiumcodereview.appspot.com/10919113/diff/5003/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc File chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc (right): https://chromiumcodereview.appspot.com/10919113/diff/5003/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc#newcode170 chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc:170: } while (retry_until_success && On 2012/09/06 18:20:51, rsesek wrote: ...
8 years, 3 months ago (2012-09-06 20:55:02 UTC) #3
Robert Sesek
lgtm
8 years, 3 months ago (2012-09-07 15:12:43 UTC) #4
scheib
sky, owner review please.
8 years, 3 months ago (2012-09-07 15:28:14 UTC) #5
sky
LGTM
8 years, 3 months ago (2012-09-07 16:17:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/10919113/5003
8 years, 3 months ago (2012-09-07 16:26:16 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 18:01:27 UTC) #8
Change committed as 155422

Powered by Google App Engine
This is Rietveld 408576698