Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 10919111: Update Windows UI for the Password Generation. (Closed)

Created:
8 years, 3 months ago by Yue Zhang
Modified:
8 years, 3 months ago
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org
Visibility:
Public.

Description

Update Windows UI for the Password Generation. Patched issue 10829373. BUG=143330 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155505

Patch Set 1 #

Patch Set 2 : Fix a build problem. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -77 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/password_generation_bubble_view.h View 5 chunks +23 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/password_generation_bubble_view.cc View 2 chunks +173 lines, -60 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Yue Zhang
Sorry for the spam but last time I didn't clear the issue number so the ...
8 years, 3 months ago (2012-09-05 23:27:57 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-06 21:23:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@chromium.org/10919111/1
8 years, 3 months ago (2012-09-06 21:28:31 UTC) #3
commit-bot: I haz the power
Try job failure for 10919111-1 (retry) on linux_rel for step "runhooks". It's a second try, ...
8 years, 3 months ago (2012-09-06 21:40:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@chromium.org/10919111/5002
8 years, 3 months ago (2012-09-06 21:59:37 UTC) #5
commit-bot: I haz the power
Try job failure for 10919111-5002 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-09-06 23:10:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@chromium.org/10919111/2003
8 years, 3 months ago (2012-09-07 02:02:29 UTC) #7
commit-bot: I haz the power
Failed to apply patch for tools/isolate/tests/isolate/files2: While running patch -p1 --forward --force; The next patch ...
8 years, 3 months ago (2012-09-07 02:02:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@chromium.org/10919111/5002
8 years, 3 months ago (2012-09-07 02:04:42 UTC) #9
commit-bot: I haz the power
Try job failure for 10919111-5002 (retry) on win_rel for step "sync_integration_tests". It's a second try, ...
8 years, 3 months ago (2012-09-07 05:23:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@chromium.org/10919111/5002
8 years, 3 months ago (2012-09-07 05:49:44 UTC) #11
commit-bot: I haz the power
Try job failure for 10919111-5002 (retry) on win_rel for step "sync_integration_tests". It's a second try, ...
8 years, 3 months ago (2012-09-07 09:05:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zysxqn@chromium.org/10919111/5002
8 years, 3 months ago (2012-09-07 19:53:24 UTC) #13
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 22:19:27 UTC) #14
Change committed as 155505

Powered by Google App Engine
This is Rietveld 408576698