Bring back service process throttler.

Bring back service process throttler.

Somewhere along the way, the service process lost it's throttler. Under certain
conditions (network going away) that meant that the service process could spin
trying to access something, eating up CPU.

BUG=140019
TEST=(Mac) Enable cloud print, disable network. Before this change, after 30 minutes, the Chromium Helper process would be >100% CPU in Activity Monitor. After this change, should be near nothing.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155050

[Scott Byer, 2012-09-05 19:00:32]

Joi, the service process seemed to have lost it's throttler in
http://src.chromium.org/viewvc/chrome?view=rev&revision=134963

This seems like the right way to add it back.

[Jói, 2012-09-05 19:19:13]

LGTM.

Sorry about that, didn't realize you were relying on the sliding
window throttling mechanism.

Cheers,
Jói


On Wed, Sep 5, 2012 at 12:00 PM,  <scottbyer@chromium.org> wrote:
> Reviewers: Albert Bodenhamer, Jói,
>
> Message:
>
> Joi, the service process seemed to have lost it's throttler in
> http://src.chromium.org/viewvc/chrome?view=rev&revision=134963
>
> This seems like the right way to add it back.
>
> Description:
> Bring back service process throttler.
>
> Somewhere along the way, the service process lost it's throttler. Under
> certain
> conditions (network going away) that meant that the service process could
> spin
> trying to access something, eating up CPU.
>
> BUG=140019
> TEST=(Mac) Enable cloud print, disable network. Before this change, after 30
> minutes, the Chromium Helper process would be >100% CPU in Activity Monitor.
> After this change, should be near nothing.
>
>
> Please review this at http://codereview.chromium.org/10919102/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/service/net/service_url_request_context.cc
>
>
> Index: chrome/service/net/service_url_request_context.cc
> diff --git a/chrome/service/net/service_url_request_context.cc
> b/chrome/service/net/service_url_request_context.cc
> index
>
1050e29d6fdc572975645593b2fee310c7178f16..a7ab6f2d2fe628f82012404c2a57be9007e99ad6
> 100644
> --- a/chrome/service/net/service_url_request_context.cc
> +++ b/chrome/service/net/service_url_request_context.cc
> @@ -25,6 +25,7 @@
>  #include "net/http/http_server_properties_impl.h"
>  #include "net/proxy/proxy_config_service.h"
>  #include "net/proxy/proxy_service.h"
> +#include "net/url_request/url_request_throttler_manager.h"
>
>  namespace {
>  // Copied from webkit/glue/user_agent.cc. We don't want to pull in a
> dependency
> @@ -123,6 +124,7 @@ ServiceURLRequestContext::ServiceURLRequestContext(
>        net::HttpAuthHandlerFactory::CreateDefault(host_resolver()));
>    storage_.set_http_server_properties(new net::HttpServerPropertiesImpl);
>    storage_.set_transport_security_state(new net::TransportSecurityState);
> +  storage_.set_throttler_manager(new net::URLRequestThrottlerManager);
>
>    net::HttpNetworkSession::Params session_params;
>    session_params.host_resolver = host_resolver();
>
>

[commit-bot: I haz the power, 2012-09-05 20:45:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottbyer@chromium.org/10919102/1

[commit-bot: I haz the power, 2012-09-05 23:35:25]

Change committed as 155050