dart/utils/compiler/buildbot.py - Issue 10919099: Disable checked mode browser tests on platforms where they break test framework.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/utils/compiler/buildbot.py

Issue 10919099: Disable checked mode browser tests on platforms where they break test framework. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/utils/compiler/buildbot.py

diff --git a/dart/utils/compiler/buildbot.py b/dart/utils/compiler/buildbot.py

index 14f096d62e406d1771ec45a00bf7941fbced770d..ba42afae6aec3589d552b20ed6727ce19e32ef90 100644

--- a/dart/utils/compiler/buildbot.py

+++ b/dart/utils/compiler/buildbot.py

@@ -339,7 +339,12 @@ def main():

status = TestCompiler(runtime, mode, system, option, test_flags,

is_buildbot)

- if status == 0:

+ if (status == 0

+ and (system == 'linux' or runtime != 'chrome')

+ and runtime != 'opera'

+ and runtime != 'ff'

+ and runtime != 'ie'

+ and runtime != 'safari'):

status = TestCompiler(runtime, mode, system, option,

test_flags + ['--checked'], is_buildbot)

« no previous file with comments | « no previous file | no next file » | no next file with comments »