content_browsertests will now use fake webrtc devices.

content_browsertests will now use fake webrtc devices.


BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155622

[phoglund_chromium, 2012-09-05 11:44:20]

This contains the fixes requested in http://codereview.chromium.org/10912070/.

[jam, 2012-09-06 16:27:19]

in the other patch, I had wondered:

re the fake rtc, another option is to use a command line flag that your harness
can set. i.e. it's unclear to me that this should be done for every test?


what do you think? afaik you're going to run this binary on your own bot. so
maybe that one can specify an extra flag, so that it's not done by default for
all tests (i.e. maybe someone wants to run this binary on a bot and wants to use
real devices).

[phoglund_chromium, 2012-09-07 08:18:41]

On 2012/09/06 16:27:19, John Abd-El-Malek wrote:
> in the other patch, I had wondered:
> 
> re the fake rtc, another option is to use a command line flag that your
harness
> can set. i.e. it's unclear to me that this should be done for every test?
> 
> 
> what do you think? afaik you're going to run this binary on your own bot. so
> maybe that one can specify an extra flag, so that it's not done by default for
> all tests (i.e. maybe someone wants to run this binary on a bot and wants to
use
> real devices).

Ah, right. Well, a WebRTC getUserMedia call will not work anyway with real
devices since the content shell delegate doesn't implement the
RequestMediaAccessPermission method (so the call will effectively be ignored). I
could implement that method to do something clever, like select the first device
in the list of available devices, but as far as I'm aware no one needs that
right now. Therefore I think we may as well make fake devices the default
alternative for now. It's easy to fix real device support later if someone needs
it.

Note that RequestMediaAccessPermission merely chooses between the available
devices, so implementing it doesn't help with the no-devices case we aim to
support with this patch.

[jam, 2012-09-07 16:05:32]

ok, lgtm

[commit-bot: I haz the power, 2012-09-09 09:40:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/10919095/1

[commit-bot: I haz the power, 2012-09-09 12:00:26]

Change committed as 155622